[Qemu-devel] should we update QEMU's u-boot submodule and binary?

[Qemu-devel] should we update QEMU's u-boot submodule and binary?

[Peter Maydell]

Hi; I just noticed that our u-boot submodule is still stuck on
a commit from 2014 when it was first added to QEMU. Should we
move this forward to some more recent u-boot release?

I think we only use this for our ppc e500 rom...

thanks
-- PMM

Re: [Qemu-devel] should we update QEMU's u-boot submodule and binary?

[Alexander Graf]

On 11.07.17 19:43, Peter Maydell wrote:
> Hi; I just noticed that our u-boot submodule is still stuck on
> a commit from 2014 when it was first added to QEMU. Should we
> move this forward to some more recent u-boot release?
> 
> I think we only use this for our ppc e500 rom...

It probably makes sense to update the e500 rom and bump the submodule to 
the latest U-Boot release along the way, yes.


U-Boot 2017.07 just got released, so now is quite a good point in time 
to do so.


Alex

Re: [Qemu-devel] should we update QEMU's u-boot submodule and binary?

[Thomas Huth]

On 11.07.2017 20:22, Alexander Graf wrote:
> 
> On 11.07.17 19:43, Peter Maydell wrote:
>> Hi; I just noticed that our u-boot submodule is still stuck on
>> a commit from 2014 when it was first added to QEMU. Should we
>> move this forward to some more recent u-boot release?
>>
>> I think we only use this for our ppc e500 rom...
> 
> It probably makes sense to update the e500 rom and bump the submodule to
> the latest U-Boot release along the way, yes.
> 
> U-Boot 2017.07 just got released, so now is quite a good point in time
> to do so.

I think we should rather update the submodule to commit 79c884d7e4 since
that is the level that is used for the pc-bios/u-boot.e500 binary (see
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=d4574435a6530bbd96ae13 ).

The problematic mv_gen_reg.h is also not part of that commit level anymore.

Alex, could you please send a patch for the update? Or shall I prepare one?

 Thomas

Re: [Qemu-devel] should we update QEMU's u-boot submodule and binary?

[Alexander Graf]

On 12.07.17 12:34, Thomas Huth wrote:
> On 11.07.2017 20:22, Alexander Graf wrote:
>>
>> On 11.07.17 19:43, Peter Maydell wrote:
>>> Hi; I just noticed that our u-boot submodule is still stuck on
>>> a commit from 2014 when it was first added to QEMU. Should we
>>> move this forward to some more recent u-boot release?
>>>
>>> I think we only use this for our ppc e500 rom...
>>
>> It probably makes sense to update the e500 rom and bump the submodule to
>> the latest U-Boot release along the way, yes.
>>
>> U-Boot 2017.07 just got released, so now is quite a good point in time
>> to do so.
> 
> I think we should rather update the submodule to commit 79c884d7e4 since
> that is the level that is used for the pc-bios/u-boot.e500 binary (see
> http://git.qemu.org/?p=qemu.git;a=commitdiff;h=d4574435a6530bbd96ae13 ).

Why not update both?

> The problematic mv_gen_reg.h is also not part of that commit level anymore.
> 
> Alex, could you please send a patch for the update? Or shall I prepare one?

I tried to compile U-Boot from 2017.07 earlier, but don't have a working 
ppc build environment anymore :(


Alex

Re: [Qemu-devel] should we update QEMU's u-boot submodule and binary?

[Thomas Huth]

On 12.07.2017 12:44, Alexander Graf wrote:
> 
> 
> On 12.07.17 12:34, Thomas Huth wrote:
>> On 11.07.2017 20:22, Alexander Graf wrote:
>>>
>>> On 11.07.17 19:43, Peter Maydell wrote:
>>>> Hi; I just noticed that our u-boot submodule is still stuck on
>>>> a commit from 2014 when it was first added to QEMU. Should we
>>>> move this forward to some more recent u-boot release?
>>>>
>>>> I think we only use this for our ppc e500 rom...
>>>
>>> It probably makes sense to update the e500 rom and bump the submodule to
>>> the latest U-Boot release along the way, yes.
>>>
>>> U-Boot 2017.07 just got released, so now is quite a good point in time
>>> to do so.
>>
>> I think we should rather update the submodule to commit 79c884d7e4 since
>> that is the level that is used for the pc-bios/u-boot.e500 binary (see
>> http://git.qemu.org/?p=qemu.git;a=commitdiff;h=d4574435a6530bbd96ae13 ).
> 
> Why not update both?

Because it needs some proper tests in that case...?

>> The problematic mv_gen_reg.h is also not part of that commit level
>> anymore.
>>
>> Alex, could you please send a patch for the update? Or shall I prepare
>> one?
> 
> I tried to compile U-Boot from 2017.07 earlier, but don't have a working
> ppc build environment anymore :(

I've never been into that e500 stuff, so I also do not have a proper
test environment for that embedded ppc stuff ==> let's update just the
submodule to 79c884d7e4 and call it a day?

 Thomas

Re: [Qemu-devel] should we update QEMU's u-boot submodule and binary?

[Alexander Graf]

On 12.07.17 12:49, Thomas Huth wrote:
> On 12.07.2017 12:44, Alexander Graf wrote:
>>
>>
>> On 12.07.17 12:34, Thomas Huth wrote:
>>> On 11.07.2017 20:22, Alexander Graf wrote:
>>>>
>>>> On 11.07.17 19:43, Peter Maydell wrote:
>>>>> Hi; I just noticed that our u-boot submodule is still stuck on
>>>>> a commit from 2014 when it was first added to QEMU. Should we
>>>>> move this forward to some more recent u-boot release?
>>>>>
>>>>> I think we only use this for our ppc e500 rom...
>>>>
>>>> It probably makes sense to update the e500 rom and bump the submodule to
>>>> the latest U-Boot release along the way, yes.
>>>>
>>>> U-Boot 2017.07 just got released, so now is quite a good point in time
>>>> to do so.
>>>
>>> I think we should rather update the submodule to commit 79c884d7e4 since
>>> that is the level that is used for the pc-bios/u-boot.e500 binary (see
>>> http://git.qemu.org/?p=qemu.git;a=commitdiff;h=d4574435a6530bbd96ae13 ).
>>
>> Why not update both?
> 
> Because it needs some proper tests in that case...?
> 
>>> The problematic mv_gen_reg.h is also not part of that commit level
>>> anymore.
>>>
>>> Alex, could you please send a patch for the update? Or shall I prepare
>>> one?
>>
>> I tried to compile U-Boot from 2017.07 earlier, but don't have a working
>> ppc build environment anymore :(
> 
> I've never been into that e500 stuff, so I also do not have a proper
> test environment for that embedded ppc stuff ==> let's update just the
> submodule to 79c884d7e4 and call it a day?

You don't need much of a test environment. Just check if it comes up in 
QEMU :).


Alex

Re: [Qemu-devel] should we update QEMU's u-boot submodule and binary?

[Thomas Huth]

On 12.07.2017 12:56, Alexander Graf wrote:
> 
> 
> On 12.07.17 12:49, Thomas Huth wrote:
>> On 12.07.2017 12:44, Alexander Graf wrote:
>>>
>>>
>>> On 12.07.17 12:34, Thomas Huth wrote:
>>>> On 11.07.2017 20:22, Alexander Graf wrote:
>>>>>
>>>>> On 11.07.17 19:43, Peter Maydell wrote:
>>>>>> Hi; I just noticed that our u-boot submodule is still stuck on
>>>>>> a commit from 2014 when it was first added to QEMU. Should we
>>>>>> move this forward to some more recent u-boot release?
>>>>>>
>>>>>> I think we only use this for our ppc e500 rom...
>>>>>
>>>>> It probably makes sense to update the e500 rom and bump the
>>>>> submodule to
>>>>> the latest U-Boot release along the way, yes.
>>>>>
>>>>> U-Boot 2017.07 just got released, so now is quite a good point in time
>>>>> to do so.
>>>>
>>>> I think we should rather update the submodule to commit 79c884d7e4
>>>> since
>>>> that is the level that is used for the pc-bios/u-boot.e500 binary (see
>>>> http://git.qemu.org/?p=qemu.git;a=commitdiff;h=d4574435a6530bbd96ae13 ).
>>>>
>>>
>>> Why not update both?
>>
>> Because it needs some proper tests in that case...?
>>
>>>> The problematic mv_gen_reg.h is also not part of that commit level
>>>> anymore.
>>>>
>>>> Alex, could you please send a patch for the update? Or shall I prepare
>>>> one?
>>>
>>> I tried to compile U-Boot from 2017.07 earlier, but don't have a working
>>> ppc build environment anymore :(
>>
>> I've never been into that e500 stuff, so I also do not have a proper
>> test environment for that embedded ppc stuff ==> let's update just the
>> submodule to 79c884d7e4 and call it a day?
> 
> You don't need much of a test environment. Just check if it comes up in
> QEMU :).

Looks like my powerpc-linux-gcc cross compiler is not suitable to build
U-Boot, it complains with an unhelpful error message:

{standard input}: Assembler messages:
{standard input}:193: Error: junk at end of line: `1'

So no binary update from my side (I really do not have spare time to
install a cross compiler for ppc embedded now) ... so unless you want to
do that, I'd really just suggest to update the submodule.

 Thomas