From: John Snow <jsnow@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Fam Zheng" <fam@euphon.net>, "Kevin Wolf" <kwolf@redhat.com>,
qemu-block@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org, "Max Reitz" <mreitz@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [Qemu-devel] [RFC PATCH v2 0/3] python: refactor qemu/__init__.py
Date: Mon, 1 Jul 2019 19:17:39 -0400 [thread overview]
Message-ID: <7bbbb0fd-2aff-d1bf-bc59-abe62b0a6a04@redhat.com> (raw)
In-Reply-To: <20190701212725.GH5198@habkost.net>
On 7/1/19 5:27 PM, Eduardo Habkost wrote:
> On Thu, Jun 27, 2019 at 05:32:17PM -0400, John Snow wrote:
>> I didn't actually mean to retain the RFC tag, but oh well.
>
> I'm queueing patch 1-2 for QEMU 4.1.
>
> Patch 3 will require more careful review. If you can demonstrate
> it fixes a problem in some use cases, we can call it a bug fix
> and include it after soft freeze. ;)
>
Right.
Mostly, it's that it ignores things like ctrl^c -- it ignores ANY
failure. I don't think that it should.
In cases where QEMU crashes, the caller will now get an exception -- but
the cleanup will still faithfully execute. There are some exceptions we
may genuinely wish to suppress here, but it's hard to enumerate which
ones without going too broadly.
It's fine to exclude this for now, but I think it's still something we
want eventually.
next prev parent reply other threads:[~2019-07-02 2:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 21:28 [Qemu-devel] [RFC PATCH v2 0/3] python: refactor qemu/__init__.py John Snow
2019-06-27 21:28 ` [Qemu-devel] [RFC PATCH v2 1/3] python/qemu: split QEMUMachine out from underneath __init__.py John Snow
2019-06-28 16:05 ` Wainer dos Santos Moschetta
2019-07-01 23:20 ` John Snow
2019-06-27 21:28 ` [Qemu-devel] [RFC PATCH v2 2/3] machine.py: minor delinting John Snow
2019-06-27 21:28 ` [Qemu-devel] [RFC PATCH v2 3/3] QEMUMachine: Don't suppress stack traces on close John Snow
2019-06-27 21:32 ` [Qemu-devel] [RFC PATCH v2 0/3] python: refactor qemu/__init__.py John Snow
2019-07-01 21:27 ` Eduardo Habkost
2019-07-01 23:17 ` John Snow [this message]
2019-07-01 23:36 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bbbb0fd-2aff-d1bf-bc59-abe62b0a6a04@redhat.com \
--to=jsnow@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).