From: Richard Henderson <richard.henderson@linaro.org>
To: Pierrick Bouvier <pierrick.bouvier@linaro.org>, qemu-devel@nongnu.org
Cc: sw@weilnetz.de, kkostiuk@redhat.com, clg@kaod.org,
alex.bennee@linaro.org, peter.maydell@linaro.org,
philmd@linaro.org
Subject: Re: [PATCH v4 2/4] sysemu/os-win32: fix setjmp/longjmp on windows-arm64
Date: Tue, 21 Feb 2023 13:45:28 -1000 [thread overview]
Message-ID: <7bc4c5b2-058c-c60c-1842-09a23fa828cd@linaro.org> (raw)
In-Reply-To: <20230221153006.20300-3-pierrick.bouvier@linaro.org>
On 2/21/23 05:30, Pierrick Bouvier wrote:
> Windows implementation of setjmp/longjmp is done in
> C:/WINDOWS/system32/ucrtbase.dll. Alas, on arm64, it seems to *always*
> perform stack unwinding, which crashes from generated code.
>
> By using alternative implementation built in mingw, we avoid doing stack
> unwinding and this fixes crash when calling longjmp.
>
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> Acked-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> include/sysemu/os-win32.h | 28 ++++++++++++++++++++++++----
> meson.build | 21 +++++++++++++++++++++
> 2 files changed, 45 insertions(+), 4 deletions(-)
Queueing this to tcg-next.
r~
next prev parent reply other threads:[~2023-02-21 23:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 15:30 [PATCH v4 0/4] Adds support for running QEMU natively on windows-arm64 Pierrick Bouvier
2023-02-21 15:30 ` [PATCH v4 1/4] util/cacheflush: fix cache " Pierrick Bouvier
2023-02-21 23:44 ` Richard Henderson
2023-02-21 15:30 ` [PATCH v4 2/4] sysemu/os-win32: fix setjmp/longjmp " Pierrick Bouvier
2023-02-21 22:27 ` Philippe Mathieu-Daudé
2023-02-22 16:08 ` Pierrick Bouvier
2023-02-22 16:17 ` Philippe Mathieu-Daudé
2023-02-21 23:45 ` Richard Henderson [this message]
2023-02-21 15:30 ` [PATCH v4 3/4] qga/vss-win32: fix warning for clang++-15 Pierrick Bouvier
2023-03-21 21:48 ` Pierrick Bouvier
2023-03-22 17:18 ` Konstantin Kostiuk
2023-03-22 17:23 ` Daniel P. Berrangé
2023-02-21 15:30 ` [PATCH v4 4/4] target/ppc: fix warning with clang-15 Pierrick Bouvier
2023-02-21 22:30 ` Philippe Mathieu-Daudé
2023-02-21 23:43 ` Richard Henderson
2023-02-22 16:02 ` Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bc4c5b2-058c-c60c-1842-09a23fa828cd@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=clg@kaod.org \
--cc=kkostiuk@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).