* [Qemu-devel] [PATCH] block: Fix leak of ignore_children in error path
@ 2018-03-15 3:51 Fam Zheng
2018-03-15 12:25 ` Eric Blake
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fam Zheng @ 2018-03-15 3:51 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf, Max Reitz, qemu-block
Reported-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
---
block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block.c b/block.c
index 75a9fd49de..c1fda9fd57 100644
--- a/block.c
+++ b/block.c
@@ -3671,12 +3671,12 @@ int bdrv_drop_intermediate(BlockDriverState *top, BlockDriverState *base,
GSList *ignore_children = g_slist_prepend(NULL, c);
bdrv_check_update_perm(base, NULL, c->perm, c->shared_perm,
ignore_children, &local_err);
+ g_slist_free(ignore_children);
if (local_err) {
ret = -EPERM;
error_report_err(local_err);
goto exit;
}
- g_slist_free(ignore_children);
/* If so, update the backing file path in the image file */
if (c->role->update_filename) {
--
2.14.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] block: Fix leak of ignore_children in error path
2018-03-15 3:51 [Qemu-devel] [PATCH] block: Fix leak of ignore_children in error path Fam Zheng
@ 2018-03-15 12:25 ` Eric Blake
2018-03-15 12:52 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2018-03-15 16:41 ` [Qemu-devel] " Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Eric Blake @ 2018-03-15 12:25 UTC (permalink / raw)
To: Fam Zheng, qemu-devel; +Cc: Kevin Wolf, qemu-block, Max Reitz
On 03/14/2018 10:51 PM, Fam Zheng wrote:
> Reported-by: Max Reitz <mreitz@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> block.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/block.c b/block.c
> index 75a9fd49de..c1fda9fd57 100644
> --- a/block.c
> +++ b/block.c
> @@ -3671,12 +3671,12 @@ int bdrv_drop_intermediate(BlockDriverState *top, BlockDriverState *base,
> GSList *ignore_children = g_slist_prepend(NULL, c);
> bdrv_check_update_perm(base, NULL, c->perm, c->shared_perm,
> ignore_children, &local_err);
> + g_slist_free(ignore_children);
> if (local_err) {
> ret = -EPERM;
> error_report_err(local_err);
> goto exit;
> }
> - g_slist_free(ignore_children);
>
> /* If so, update the backing file path in the image file */
> if (c->role->update_filename) {
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [Qemu-block] [PATCH] block: Fix leak of ignore_children in error path
2018-03-15 3:51 [Qemu-devel] [PATCH] block: Fix leak of ignore_children in error path Fam Zheng
2018-03-15 12:25 ` Eric Blake
@ 2018-03-15 12:52 ` Alberto Garcia
2018-03-15 16:41 ` [Qemu-devel] " Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Alberto Garcia @ 2018-03-15 12:52 UTC (permalink / raw)
To: Fam Zheng, qemu-devel; +Cc: Kevin Wolf, qemu-block, Max Reitz
On Thu 15 Mar 2018 04:51:57 AM CET, Fam Zheng wrote:
> Reported-by: Max Reitz <mreitz@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Berto
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] block: Fix leak of ignore_children in error path
2018-03-15 3:51 [Qemu-devel] [PATCH] block: Fix leak of ignore_children in error path Fam Zheng
2018-03-15 12:25 ` Eric Blake
2018-03-15 12:52 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
@ 2018-03-15 16:41 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Kevin Wolf @ 2018-03-15 16:41 UTC (permalink / raw)
To: Fam Zheng; +Cc: qemu-devel, Max Reitz, qemu-block
Am 15.03.2018 um 04:51 hat Fam Zheng geschrieben:
> Reported-by: Max Reitz <mreitz@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-15 16:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-15 3:51 [Qemu-devel] [PATCH] block: Fix leak of ignore_children in error path Fam Zheng
2018-03-15 12:25 ` Eric Blake
2018-03-15 12:52 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2018-03-15 16:41 ` [Qemu-devel] " Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).