From: Helge Deller <deller@gmx.de>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Sven Schnelle" <svens@stackframe.org>,
qemu-devel@nongnu.org
Cc: Richard Henderson <rth@twiddle.net>
Subject: Re: [RFC PATCH 4/4] hw/hppa/dino: Do not accept accesses to registers 0x818 and 0x82c
Date: Sat, 15 Feb 2020 21:49:47 +0100 [thread overview]
Message-ID: <7bd7bf7b-2c7e-86d0-7aee-c379df4373f7@gmx.de> (raw)
In-Reply-To: <20200213234148.8434-5-f4bug@amsat.org>
On 14.02.20 00:41, Philippe Mathieu-Daudé wrote:
> Register 0x818 is documented as 'undefined', and register
> 0x82c is not documented. Refuse their access.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Acked-by: Helge Deller <deller@gmx.de>
> ---
> hw/hppa/dino.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/hppa/dino.c b/hw/hppa/dino.c
> index be799aad43..2b1b38c58a 100644
> --- a/hw/hppa/dino.c
> +++ b/hw/hppa/dino.c
> @@ -181,7 +181,9 @@ static bool dino_chip_mem_valid(void *opaque, hwaddr addr,
> case DINO_IO_ADDR_EN:
> case DINO_PCI_IO_DATA:
> case DINO_TOC_ADDR:
> - case DINO_GMASK ... DINO_TLTIM:
> + case DINO_GMASK ... DINO_PCISTS:
> + case DINO_MLTIM ... DINO_PCIWOR:
> + case DINO_TLTIM:
> ret = true;
> break;
> case DINO_PCI_IO_DATA + 2:
>
next prev parent reply other threads:[~2020-02-15 20:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 23:41 [PATCH 0/4] hw/hppa/dino: Fix Coverity 1419393 & 1419394 Philippe Mathieu-Daudé
2020-02-13 23:41 ` [PATCH 1/4] hw/hppa/dino: Add comments with register name Philippe Mathieu-Daudé
2020-02-15 19:59 ` Helge Deller
2020-02-13 23:41 ` [PATCH 2/4] hw/hppa/dino: Fix reg800_keep_bits[] overrun (CID 1419393 & 1419394) Philippe Mathieu-Daudé
2020-02-15 20:08 ` Helge Deller
2020-02-17 17:37 ` Peter Maydell
2020-02-18 6:19 ` Philippe Mathieu-Daudé
2020-02-18 6:28 ` Philippe Mathieu-Daudé
2020-02-13 23:41 ` [RFC PATCH 3/4] hw/hppa/dino: Fix PCIROR register access bitmask Philippe Mathieu-Daudé
2020-02-15 20:49 ` Helge Deller
2020-02-13 23:41 ` [RFC PATCH 4/4] hw/hppa/dino: Do not accept accesses to registers 0x818 and 0x82c Philippe Mathieu-Daudé
2020-02-15 20:49 ` Helge Deller [this message]
2020-02-16 1:44 ` [PATCH 0/4] hw/hppa/dino: Fix Coverity 1419393 & 1419394 Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bd7bf7b-2c7e-86d0-7aee-c379df4373f7@gmx.de \
--to=deller@gmx.de \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=svens@stackframe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).