From: Eric Blake <eblake@redhat.com>
To: Yi Min Zhao <zyimin@linux.ibm.com>, qemu-devel@nongnu.org
Cc: otubo@redhat.com, fiuczy@linux.ibm.com, jtomko@redhat.com,
borntraeger@de.ibm.com, jferlan@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 1/1] sandbox: disable -sandbox if CONFIG_SECCOMP undefined
Date: Tue, 15 May 2018 10:25:46 -0500 [thread overview]
Message-ID: <7bd9074b-04ca-49f6-096b-808d36e4e8b0@redhat.com> (raw)
In-Reply-To: <20180515113348.10516-2-zyimin@linux.ibm.com>
On 05/15/2018 06:33 AM, Yi Min Zhao wrote:
> If CONFIG_SECCOMP is undefined, the option 'elevateprivileges' remains
> compiled. This would make libvirt set the corresponding capability and
> then trigger the guest startup fails. So this patch excludes the code
s/trigger the guest startup fails/trigger failure during guest startup/
> regarding seccomp staff if CONFIG_SECCOMP is undefined.
s/staff/command line options/
>
> Signed-off-by: Yi Min Zhao <zyimin@linux.ibm.com>
> ---
> vl.c | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
A maintainer can touch up the commit message, so:
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-05-15 15:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 11:33 [Qemu-devel] [PATCH v2 0/1] Bug: Sandbox: libvirt breakdowns qemu guest Yi Min Zhao
2018-05-15 11:33 ` [Qemu-devel] [PATCH v2 1/1] sandbox: disable -sandbox if CONFIG_SECCOMP undefined Yi Min Zhao
2018-05-15 15:25 ` Eric Blake [this message]
2018-05-16 1:05 ` Yi Min Zhao
2018-05-17 11:33 ` Yi Min Zhao
2018-05-17 12:41 ` Eduardo Otubo
2018-05-17 14:36 ` Yi Min Zhao
2018-05-18 7:52 ` Ján Tomko
2018-05-18 9:19 ` Eduardo Otubo
2018-05-18 13:07 ` Ján Tomko
2018-05-19 8:20 ` Yi Min Zhao
2018-05-23 7:47 ` Ján Tomko
2018-05-23 9:16 ` Yi Min Zhao
2018-05-23 10:33 ` Eduardo Otubo
2018-05-23 12:17 ` Yi Min Zhao
2018-05-24 7:53 ` Eduardo Otubo
2018-05-24 13:40 ` Paolo Bonzini
2018-05-25 4:23 ` Yi Min Zhao
2018-05-25 9:36 ` Eduardo Otubo
2018-05-28 12:55 ` Yi Min Zhao
2018-05-18 12:08 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bd9074b-04ca-49f6-096b-808d36e4e8b0@redhat.com \
--to=eblake@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=fiuczy@linux.ibm.com \
--cc=jferlan@redhat.com \
--cc=jtomko@redhat.com \
--cc=otubo@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zyimin@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).