qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Denis Plotnikov <dplotnikov@virtuozzo.com>, qemu-block@nongnu.org
Cc: kwolf@redhat.com, den@virtuozzo.com, armbru@redhat.com,
	qemu-devel@nongnu.org, mreitz@redhat.com, dgilbert@redhat.com
Subject: Re: [PATCH] blockdev: modify blockdev-change-medium to change non-removable device
Date: Fri, 18 Oct 2019 09:35:18 -0500	[thread overview]
Message-ID: <7bdd4dcf-da43-6169-382f-32b248ec72bb@redhat.com> (raw)
In-Reply-To: <20191018120950.26849-1-dplotnikov@virtuozzo.com>

On 10/18/19 7:09 AM, Denis Plotnikov wrote:
> The modification is useful to workaround exclusive file access restrictions,
> e.g. to implement VM migration with shared disk stored on a storage with
> the exclusive file opening model: a destination VM is started waiting for
> incomming migration with a fake image drive, and later, on the last migration
> phase, the fake image file is replaced with the real one.
> 
> Signed-off-by: Denis Plotnikov <dplotnikov@virtuozzo.com>
> ---

> +++ b/qapi/block-core.json
> @@ -4769,6 +4769,8 @@
>   # @read-only-mode:  change the read-only mode of the device; defaults
>   #                   to 'retain'
>   #
> +# @medium-name:     drive-name when changing the media in non-removable devices
> +#                   ignored when changing media in removable devices

s/devices ignored/devices. Ignored/

Missing a '(since 4.2)' tag.


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


  reply	other threads:[~2019-10-18 14:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-18 12:09 [PATCH] blockdev: modify blockdev-change-medium to change non-removable device Denis Plotnikov
2019-10-18 14:35 ` Eric Blake [this message]
2019-10-18 15:02 ` Max Reitz
2019-10-21  6:50   ` Denis Plotnikov
2019-10-22 11:05     ` Max Reitz
2019-10-22 12:53       ` Denis Plotnikov
2019-10-22 13:18         ` Max Reitz
2019-10-22 13:24           ` Denis Plotnikov
2019-10-23 13:56       ` Vladimir Sementsov-Ogievskiy
2019-10-23 14:10         ` Vladimir Sementsov-Ogievskiy
2019-10-24  9:31           ` Max Reitz
2019-10-23 16:02         ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7bdd4dcf-da43-6169-382f-32b248ec72bb@redhat.com \
    --to=eblake@redhat.com \
    --cc=armbru@redhat.com \
    --cc=den@virtuozzo.com \
    --cc=dgilbert@redhat.com \
    --cc=dplotnikov@virtuozzo.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).