From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58036) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fa64f-0000qR-JW for qemu-devel@nongnu.org; Mon, 02 Jul 2018 17:09:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fa64b-0004AW-KO for qemu-devel@nongnu.org; Mon, 02 Jul 2018 17:09:29 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35610 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fa64b-0004AC-Ft for qemu-devel@nongnu.org; Mon, 02 Jul 2018 17:09:25 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 330054021CC2 for ; Mon, 2 Jul 2018 21:09:25 +0000 (UTC) References: <20180702162218.13678-1-armbru@redhat.com> <20180702162218.13678-7-armbru@redhat.com> From: Eric Blake Message-ID: <7be32466-2ee0-db09-2ced-5027eef5bb02@redhat.com> Date: Mon, 2 Jul 2018 16:09:20 -0500 MIME-Version: 1.0 In-Reply-To: <20180702162218.13678-7-armbru@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 06/32] tests/qmp-test: Test in-band command doesn't overtake List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: peterx@redhat.com, stefanha@redhat.com, dgilbert@redhat.com On 07/02/2018 11:21 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > tests/qmp-test.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/qmp-test.c b/tests/qmp-test.c > index b4e54e8970..3932901146 100644 > --- a/tests/qmp-test.c > +++ b/tests/qmp-test.c > @@ -236,10 +236,12 @@ static void test_qmp_oob(void) > /* OOB command overtakes slow in-band command */ > setup_blocking_cmd(); > send_cmd_that_blocks(qts, "ib-blocks-1"); > + qtest_async_qmp(qts, "{ 'execute': 'query-name', 'id': 'ib-quick-1' }"); > send_oob_cmd(qts, "oob-1"); > recv_cmd_id(qts, "oob-1"); > unblock_blocked_cmd(); > recv_cmd_id(qts, "ib-blocks-1"); > + recv_cmd_id(qts, "ib-quick-1"); > cleanup_blocking_cmd(); Nice improvement. Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org