From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1qUU-0003Mq-UJ for qemu-devel@nongnu.org; Tue, 10 Oct 2017 05:06:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1qUP-0001R1-Td for qemu-devel@nongnu.org; Tue, 10 Oct 2017 05:06:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45460) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e1qUP-0001QM-N3 for qemu-devel@nongnu.org; Tue, 10 Oct 2017 05:06:13 -0400 References: <20170911174933.20789-1-david@redhat.com> <20170911174933.20789-6-david@redhat.com> From: Thomas Huth Message-ID: <7bf188b3-3c35-97ef-f67d-7ffabe45c4a1@redhat.com> Date: Tue, 10 Oct 2017 11:06:04 +0200 MIME-Version: 1.0 In-Reply-To: <20170911174933.20789-6-david@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 5/6] kvm: kvm_log_start/stop are only called with known sections List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand , qemu-devel@nongnu.org Cc: Paolo Bonzini , kvm@vger.kernel.org, =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= On 11.09.2017 19:49, David Hildenbrand wrote: > Let's properly align the sections first and bail out if we would ever > get called with a memory section we don't know yet. > > Signed-off-by: David Hildenbrand > --- > accel/kvm/kvm-all.c | 18 ++++++++++++------ > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c > index b677d1b13e..2ae459453d 100644 > --- a/accel/kvm/kvm-all.c > +++ b/accel/kvm/kvm-all.c > @@ -411,15 +411,21 @@ static int kvm_slot_update_flags(KVMMemoryListener *kml, KVMSlot *mem, > static int kvm_section_update_flags(KVMMemoryListener *kml, > MemoryRegionSection *section) > { > - hwaddr phys_addr = section->offset_within_address_space; > - ram_addr_t size = int128_get64(section->size); > - KVMSlot *mem = kvm_lookup_matching_slot(kml, phys_addr, size); > + hwaddr start_addr, size; > + KVMSlot *mem; > > - if (mem == NULL) { > + size = kvm_align_section(section, &start_addr); > + if (!size) { > return 0; > - } else { > - return kvm_slot_update_flags(kml, mem, section->mr); > } > + > + mem = kvm_lookup_matching_slot(kml, start_addr, size); > + if (!mem) { > + fprintf(stderr, "%s: error finding slot\n", __func__); > + abort(); > + } FYI, this abort now triggers with the "isa-vga" device: $ x86_64-softmmu/qemu-system-x86_64 -S -accel kvm -device isa-vga kvm_section_update_flags: error finding slot Aborted (core dumped) Any ideas how to fix this? Thomas