qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Lieven <pl@kamp.de>, qemu block <qemu-block@nongnu.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage
Date: Tue, 20 Feb 2018 22:54:35 +0100	[thread overview]
Message-ID: <7c23f28d-ee14-c504-ae13-04414c4b032e@redhat.com> (raw)
In-Reply-To: <7b01ba4b-7f5f-30c7-d6d8-3c22f2774e7e@kamp.de>

On 20/02/2018 18:04, Peter Lieven wrote:
> Hi,
> 
> I remember we discussed a long time ago to limit the stack usage of all
> functions that are executed in a coroutine
> context to a very low value to be able to safely limit the coroutine
> stack size as well.

IIRC the only issue was that hw/ide/atapi.c has mutual recursion between
ide_atapi_cmd_reply_end -> ide_transfer_start -> ahci_start_transfer ->
ide_atapi_cmd_reply_end.

But perhaps it's not an issue, somebody needs to audit the code.

> I checked through all functions in block/, migration/ and nbd/ and there
> are only very few larger or unbound stack
> allocations that can easily be fixed.

Yeah, the really large allocations are very few and mostly have to do
with networking (https://wiki.qemu.org/BiteSizedTasks#Large_frames).
Unfortunately the link to the original list has died together with the
gmane archives.

Paolo

  reply	other threads:[~2018-02-20 21:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-20 17:04 [Qemu-devel] Limiting coroutine stack usage Peter Lieven
2018-02-20 21:54 ` Paolo Bonzini [this message]
2018-02-22 10:57   ` [Qemu-devel] [Qemu-block] " Kevin Wolf
2018-02-22 11:01     ` Peter Lieven
2018-02-22 11:32       ` Kevin Wolf
2018-02-22 11:40         ` Daniel P. Berrangé
2018-02-22 11:51           ` Peter Lieven
2018-02-22 12:00             ` Daniel P. Berrangé
2018-02-22 12:02               ` Peter Lieven
2018-02-22 12:03                 ` Daniel P. Berrangé
2018-02-22 12:06                   ` Peter Lieven
2018-02-22 12:16                     ` Daniel P. Berrangé
2018-02-22 12:19                     ` Kevin Wolf
2018-02-22 11:42         ` Peter Lieven
2018-02-22 17:06     ` John Snow
2018-02-23 11:17       ` Paolo Bonzini
2018-03-06 11:51 ` Stefan Hajnoczi
2018-03-07 20:36   ` Peter Lieven
2018-03-08 17:27     ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c23f28d-ee14-c504-ae13-04414c4b032e@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=pl@kamp.de \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).