Re: [Qemu-devel] [PATCH 2/3] tests: add qtest_set_exit_status()

[Thomas Huth <thuth@redhat.com>]

On 08/07/2019 09.24, Marc-André Lureau wrote:
> Modify the behaviour of qtest_quit() to check against the expected
> exit status value. The default remains 0.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  tests/libqtest.c | 41 ++++++++++++++++++++++-------------------
>  tests/libqtest.h |  9 +++++++++
>  2 files changed, 31 insertions(+), 19 deletions(-)
> 
> diff --git a/tests/libqtest.c b/tests/libqtest.c
> index 3c5c3f49d8..d722de6da8 100644
> --- a/tests/libqtest.c
> +++ b/tests/libqtest.c
> @@ -46,6 +46,7 @@ struct QTestState
>      bool big_endian;
>      bool irq_level[MAX_IRQ];
>      GString *rx;
> +    int exit_status;

Could you please call the variable "expected_exit_status" or
"expected_status"? I think that's less confusing.

 Thanks,
  Thomas