Re: [PATCH] hw/input: expand trace info reported for ps2 device

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 12/8/20 12:59 PM, Daniel P. Berrangé wrote:
> It is interesting to know if the PS2 keyboard is in translated mode, and
> which of the three scancode sets are in use.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  hw/input/ps2.c        | 2 +-
>  hw/input/trace-events | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/input/ps2.c b/hw/input/ps2.c
> index 72cdb80ae1..237956aca2 100644
> --- a/hw/input/ps2.c
> +++ b/hw/input/ps2.c
> @@ -293,7 +293,7 @@ static void ps2_keyboard_event(DeviceState *dev, QemuConsole *src,
>      qcode = qemu_input_key_value_to_qcode(key->key);
>  
>      mod = ps2_modifier_bit(qcode);
> -    trace_ps2_keyboard_event(s, qcode, key->down, mod, s->modifiers);
> +    trace_ps2_keyboard_event(s, qcode, key->down, mod, s->modifiers, s->scancode_set, s->translate);

Long line...

Anyway,
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>