From: Eric Blake <eblake@redhat.com>
To: Michael Clark <mjc@sifive.com>, Thomas Huth <thuth@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Palmer Dabbelt <palmer@sifive.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Sagar Karandikar <sagark@eecs.berkeley.edu>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Subject: Re: [Qemu-devel] [PULL 00/25] RISC-V Post-merge spec conformance and cleanup
Date: Wed, 21 Mar 2018 13:40:15 -0500 [thread overview]
Message-ID: <7c3c9825-1df1-ec9e-a9a5-bae1c5152d5d@redhat.com> (raw)
In-Reply-To: <CAHNT7NvJ42AApKcprrZ+s7bMxxbL1S1ZdX9aTjQTwd=fbFQU6w@mail.gmail.com>
On 03/21/2018 01:27 PM, Michael Clark wrote:
>> for future PULL request, could you please send out all patches again
>> that should be pulled, and not send the cover letter alone? I.e. do a
>> "git format-patch --subject-prefix PULL ..." and then replace the
>> contents of the cover letter with the output of "git request-pull".
>>
>
> No problem. Thanks for the advice. I was grappling with this part of the
> process. This is now very clear and makes complete sense.
You'll notice that some maintainers send a full PULL request the first
time, but if they have to send a v2, they only include the patches that
changed from v1. That's also okay (there's still an email for each
patch in the series as it eventually got committed, even if it is now
split across threads; but that is sufficient for someone performing a
bisect to have an easy email to reply to when reporting a regression
caused by the final version that ended up getting pulled). For an
example of that, see my QAPI v4 request:
https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg05160.html
and the regression report against the v1 request (since that particular
patch did not change between v1 and v4):
https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg03611.html
https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg05709.html
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-03-21 18:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 22:25 [Qemu-devel] [PULL 00/25] RISC-V Post-merge spec conformance and cleanup Michael Clark
2018-03-20 22:43 ` Michael Clark
2018-03-21 7:05 ` Thomas Huth
2018-03-21 9:28 ` Laurent Vivier
2018-03-21 11:09 ` Paolo Bonzini
2018-03-21 18:04 ` Michael Clark
2018-03-21 18:27 ` Michael Clark
2018-03-21 18:40 ` Eric Blake [this message]
2018-03-22 9:56 ` Philippe Mathieu-Daudé
2018-03-22 18:26 ` Michael Clark
2018-03-22 19:10 ` Peter Maydell
2018-03-22 19:38 ` Eric Blake
2018-03-23 10:20 ` Peter Maydell
2018-03-24 18:34 ` Michael Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c3c9825-1df1-ec9e-a9a5-bae1c5152d5d@redhat.com \
--to=eblake@redhat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=mjc@sifive.com \
--cc=palmer@sifive.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sagark@eecs.berkeley.edu \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).