From: Richard Henderson <richard.henderson@linaro.org>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: Re: [PATCH] qemu/osdep: Remove fallback for MAP_FIXED_NOREPLACE
Date: Tue, 8 Aug 2023 20:51:27 -0700 [thread overview]
Message-ID: <7c3f2510-ea9a-927d-adb1-4f74d05f72b5@linaro.org> (raw)
In-Reply-To: <be628c0f-19a9-6710-e132-f958f55cd0f3@tls.msk.ru>
On 8/8/23 20:50, Michael Tokarev wrote:
> 08.08.2023 19:44, Richard Henderson пишет:
>> In order for our emulation of MAP_FIXED_NOREPLACE to succeed within
>> linux-user target_mmap, we require a non-zero value. This does not
>> require host kernel support, merely the bit being defined.
>
> Hm. Should we add something like
>
> assert(MAP_FIXED_NOREPLACE != 0)
>
> somewhere?
I wouldn't think so. Where would a zero come from?
r~
prev parent reply other threads:[~2023-08-09 3:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 16:44 [PATCH] qemu/osdep: Remove fallback for MAP_FIXED_NOREPLACE Richard Henderson
2023-08-08 22:16 ` Alex Bennée
2023-08-09 3:43 ` Akihiko Odaki
2023-08-09 3:50 ` Michael Tokarev
2023-08-09 3:51 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c3f2510-ea9a-927d-adb1-4f74d05f72b5@linaro.org \
--to=richard.henderson@linaro.org \
--cc=akihiko.odaki@daynix.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).