Re: [PATCH 12/12] error: Kill @error_warn

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 8/8/25 10:08, Markus Armbruster wrote:
> We added @error_warn some two years ago in commit 3ffef1a55ca (error:
> add global &error_warn destination).  It has multiple issues:
> 
> * error.h's big comment was not updated for it.
> 
> * Function contracts were not updated for it.
> 
> * ERRP_GUARD() is unaware of @error_warn, and fails to mask it from
>    error_prepend() and such.  These crash on @error_warn, as pointed
>    out by Akihiko Odaki.
> 
> All fixable.  However, after more than two years, we had just of 15
> uses, of which the last few patches removed eight as unclean or
> otherwise undesirable.  I didn't look closely enough at the remaining
> seven to decide whether they are desirable or not.

Is it a call for help? If so, better to split this patch per
maintained areas, and finally kill @error_warn.

> 
> I don't think this feature earns its keep.  Drop it.
> 
> Thanks-to: Akihiko  Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   include/qapi/error.h           |  6 ------
>   hw/display/virtio-gpu.c        |  8 ++++++--
>   hw/net/virtio-net.c            |  8 +++++++-
>   tests/unit/test-error-report.c | 17 -----------------
>   ui/gtk.c                       |  6 +++++-
>   util/error.c                   |  5 +----
>   6 files changed, 19 insertions(+), 31 deletions(-)