From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51E5DC433EF for ; Sat, 9 Apr 2022 20:54:41 +0000 (UTC) Received: from localhost ([::1]:57896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ndI6S-0004Yd-Gu for qemu-devel@archiver.kernel.org; Sat, 09 Apr 2022 16:54:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37574) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndI5K-0002TF-Iq for qemu-devel@nongnu.org; Sat, 09 Apr 2022 16:53:31 -0400 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:46599) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ndI5J-0005wo-1M for qemu-devel@nongnu.org; Sat, 09 Apr 2022 16:53:30 -0400 Received: by mail-pl1-x634.google.com with SMTP id be5so4838302plb.13 for ; Sat, 09 Apr 2022 13:53:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=9RBShkMvp/3tGtI7eoNovtDiFs3ApIbKkhLHwibBIz8=; b=fYHwS73IRYl5hvTySBo/6v/sEqBtnXK5eFc/z3YLACC9xpQvB8F4pfd9G/J/BXn7Du Ej/C7F82sNqaIHOqdZsNCEz0HJ/P0aM4egp1d5tfi5ARwCRM4mKKJlmWwfLrW6TwU2wY nvtQKKPbRatvBC8xv11Jy5BXMTqj3FxPSNw3gE3HfHZG4Oe3Wnm4FNCtiEj1lIM2ZdmD BHwRJ6YQRDErSMJ7+FOIoj7tr12Vi1e5+MRNNX4VEoGoSMqhmpgh6f6iz8WZGLJXgUK1 GhayuYsytWGxlIMA4HSptxwG12mBsB5+NFZhkSShgF3/Kh50RWMYlYNhIT1ydF0GAYVU 7LbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=9RBShkMvp/3tGtI7eoNovtDiFs3ApIbKkhLHwibBIz8=; b=2R6E28PT/tRT5XSFt/aJLdNbx1AkXlwNWxJ3M2r5kBfkoqVXjYcEA58D9BTbyJuBij SqxaYIwLQUU7UMbyx+lZz8LPWUQ8TvQRAWtWRayZU3V5B4p8Mls1LgL6Y2GygE98w51H UPWSQX7uwksD9UmUc5e3IZAdYhCb8TJ0A/ZP/TW6PUvi28IwWKJFjFj/gpK8aFfn00Wn XdwLGrfjWQ208lqbbNuyPJjMbAn10CmfXun7nEWX4zVkit4WBg0lSfXslW6FgnkjL+Cu OOMv+8MHQC0h3NLzZqGFMbHy52L8v3uQQQTBKtA/3wh0LPFzr4gq1EGISNFwIeWoFNkf 0wpA== X-Gm-Message-State: AOAM530SucbxX8UTXvNJR4VXlneH5A3zUXlgA+ONZZj9fSsUkBPbbW1o p68mt82ipC2SKIF8+p06uR4FsQ== X-Google-Smtp-Source: ABdhPJzuRJEU/UPgQfvZTY1IR8w8LYyYvmTDt1hErpyNs52NhbmOnLHZU+UDNXrSnmw3SHbb08GlEw== X-Received: by 2002:a17:902:868b:b0:156:7afb:2ce2 with SMTP id g11-20020a170902868b00b001567afb2ce2mr25365002plo.27.1649537607711; Sat, 09 Apr 2022 13:53:27 -0700 (PDT) Received: from [192.168.1.6] (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id v3-20020aa78503000000b00504e93ef182sm9966857pfn.31.2022.04.09.13.53.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 Apr 2022 13:53:27 -0700 (PDT) Message-ID: <7c596717-09d1-f4b4-6f49-eb357e7f0139@linaro.org> Date: Sat, 9 Apr 2022 13:53:25 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 40/41] hw/arm/virt: Abstract out calculation of redistributor region capacity Content-Language: en-US To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20220408141550.1271295-1-peter.maydell@linaro.org> <20220408141550.1271295-41-peter.maydell@linaro.org> From: Richard Henderson In-Reply-To: <20220408141550.1271295-41-peter.maydell@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::634; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marc Zyngier Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/8/22 07:15, Peter Maydell wrote: > In several places in virt.c we calculate the number of redistributors that > fit in a region of our memory map, which is the size of the region > divided by the size of a single redistributor frame. For GICv4, the > redistributor frame is a different size from that for GICv3. Abstract > out the calculation of redistributor region capacity so that we have > one place we need to change to handle GICv4 rather than several. > > Signed-off-by: Peter Maydell > --- > include/hw/arm/virt.h | 9 +++++++-- > hw/arm/virt.c | 11 ++++------- > 2 files changed, 11 insertions(+), 9 deletions(-) Reviewed-by: Richard Henderson r~