From: Richard Henderson <richard.henderson@linaro.org>
To: David Miller <dmiller423@gmail.com>
Cc: Thomas Huth <thuth@redhat.com>,
David Hildenbrand <david@redhat.com>,
farman@linux.ibm.com, cohuck@redhat.com, qemu-devel@nongnu.org,
pasic@linux.ibm.com, qemu-s390x@nongnu.org,
Christian Borntraeger <borntraeger@linux.ibm.com>
Subject: Re: [PATCH v2] tests/tcg/s390x: Cleanup of mie3 tests.
Date: Tue, 1 Mar 2022 11:18:29 -1000 [thread overview]
Message-ID: <7c621228-8854-8923-7c8e-0b66ba03063f@linaro.org> (raw)
In-Reply-To: <CAEgyohWeLd1Wn6FmEKpgFHFskAiMfcpu778Re2ZHr5-zBq70Zg@mail.gmail.com>
On 3/1/22 10:22, David Miller wrote:
> However the constraint must be wrong there.
> Sorry about split message.
>
> On Tue, Mar 1, 2022 at 3:21 PM David Miller <dmiller423@gmail.com
> <mailto:dmiller423@gmail.com>> wrote:
>
> I used
>
>
> #define Fi3(S, ASM) uint64_t S(uint64_t a, uint64_t b, uint64_t c) \
> { \
> uint64_t res= 0; \
> asm volatile ( \
> "ltgr %[c], %[c]\n" \
> ASM \
> "stg %[c], %[res] " \
> : [res]"=&r" (res) \
> : [a]"r" (a), \
> [b]"r" (b), \
> [c]"r" (c) \
> ); \
> return res; \
> }
>
>
The final stg is wrong and unnecessary.
r~
prev parent reply other threads:[~2022-03-01 21:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 19:59 [PATCH v2] tests/tcg/s390x: Cleanup of mie3 tests David Miller
2022-03-01 20:15 ` Richard Henderson
2022-03-01 20:21 ` David Miller
2022-03-01 20:22 ` David Miller
2022-03-01 21:18 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c621228-8854-8923-7c8e-0b66ba03063f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=dmiller423@gmail.com \
--cc=farman@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).