qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gavin Shan <gshan@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Alexey Kardashevskiy" <aik@ozlabs.ru>,
	qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>
Subject: Re: [PATCH] hw/nmi: Fix the NMI() macro, based on INTERFACE_CHECK()
Date: Sun, 8 Dec 2019 00:44:16 +1100	[thread overview]
Message-ID: <7c698f75-5be4-de98-2e8a-c271ae4c28d8@redhat.com> (raw)
In-Reply-To: <20191207094823.20707-1-philmd@redhat.com>

On 12/7/19 8:48 PM, Philippe Mathieu-Daudé wrote:
> There is no declaration of the 'NMI' type. INTERFACE_CHECK()
> returns an abstract type (see commit aa1b35b975d8). The abstract
> type corresponding to the TYPE_NMI interface is 'NMIState'.
> 
> Fixes: 9cb805fd267
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---

Reviewed-by: Gavin Shan <gshan@redhat.com>

>   include/hw/nmi.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/hw/nmi.h b/include/hw/nmi.h
> index a1e128724e..fe37ce3ad8 100644
> --- a/include/hw/nmi.h
> +++ b/include/hw/nmi.h
> @@ -31,7 +31,7 @@
>   #define NMI_GET_CLASS(obj) \
>       OBJECT_GET_CLASS(NMIClass, (obj), TYPE_NMI)
>   #define NMI(obj) \
> -     INTERFACE_CHECK(NMI, (obj), TYPE_NMI)
> +     INTERFACE_CHECK(NMIState, (obj), TYPE_NMI)
>   
>   typedef struct NMIState NMIState;
>   
> 



  reply	other threads:[~2019-12-07 16:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-07  9:48 [PATCH] hw/nmi: Fix the NMI() macro, based on INTERFACE_CHECK() Philippe Mathieu-Daudé
2019-12-07 13:44 ` Gavin Shan [this message]
2019-12-13 20:08   ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c698f75-5be4-de98-2e8a-c271ae4c28d8@redhat.com \
    --to=gshan@redhat.com \
    --cc=aik@ozlabs.ru \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).