From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org
Subject: Re: [PATCH] target/arm: Handle denormals correctly for FMOPA (widening)
Date: Wed, 31 Jul 2024 08:36:24 +1000 [thread overview]
Message-ID: <7c9662a0-240b-4bf5-9676-5eff403f86ef@linaro.org> (raw)
In-Reply-To: <20240730155819.2958924-1-peter.maydell@linaro.org>
On 7/31/24 01:58, Peter Maydell wrote:
> -void HELPER(sme_fmopa_h)(void *vza, void *vzn, void *vzm, void *vpn,
> - void *vpm, void *vst, uint32_t desc)
> +void HELPER(sme_fmopa_h)(CPUARMState *env,
> + void *vza, void *vzn, void *vzm, void *vpn,
> + void *vpm, uint32_t desc)
I think the env pointer should replace vst in the argument ordering.
That keeps with the standard gvec signature.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2024-07-30 22:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 15:58 [PATCH] target/arm: Handle denormals correctly for FMOPA (widening) Peter Maydell
2024-07-30 22:36 ` Richard Henderson [this message]
2024-07-31 8:29 ` Peter Maydell
2024-07-31 16:26 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c9662a0-240b-4bf5-9676-5eff403f86ef@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).