From: Richard Henderson <richard.henderson@linaro.org>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cohuck@redhat.com>
Cc: Alexander Graf <agraf@suse.de>, Thomas Huth <thuth@redhat.com>,
Halil Pasic <pasic@linux.vnet.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>,
qemu-s390x <qemu-s390x@nongnu.org>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 2/2] pc-bios/s390-ccw: zero out bss section
Date: Thu, 23 Nov 2017 08:32:26 +0100 [thread overview]
Message-ID: <7ca173f9-c4f3-2daa-04b0-38b4ade27504@linaro.org> (raw)
In-Reply-To: <20171122142627.73170-3-borntraeger@de.ibm.com>
On 11/22/2017 03:26 PM, Christian Borntraeger wrote:
> The QEMU ELF loader does not zero the bss segment.
> This resulted in several bugs, e.g. see
>
> commit 5d739a4787a5 (s390-ccw.img: Fix sporadic errors with ccw boot image - initialize css)
> commit 6a40fa2669d3 (s390-ccw.img: Initialize next_idx)
> commit 8775d91a0f42 (pc-bios/s390-ccw: Fix problem with invalid virtio-scsi LUN when rebooting)
>
> Lets fix this once and forever by letting the BIOS zero the bss itself.
>
> Suggested-by: Alexander Graf <agraf@suse.de>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> pc-bios/s390-ccw/start.S | 30 +++++++++++++++++++++++++++---
> 1 file changed, 27 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2017-11-23 7:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 14:26 [Qemu-devel] [PATCH 0/2] s390x fixes (post 2.11) Christian Borntraeger
2017-11-22 14:26 ` [Qemu-devel] [PATCH 1/2] s390x/migration: use zero flag parameter Christian Borntraeger
2017-11-22 14:37 ` Thomas Huth
2017-11-22 14:49 ` Cornelia Huck
2017-11-22 14:43 ` Cornelia Huck
2017-11-22 14:50 ` Christian Borntraeger
2017-11-22 14:26 ` [Qemu-devel] [PATCH 2/2] pc-bios/s390-ccw: zero out bss section Christian Borntraeger
2017-11-22 14:45 ` Cornelia Huck
2017-11-22 16:36 ` Thomas Huth
2017-11-23 7:32 ` Richard Henderson [this message]
2017-11-22 14:46 ` [Qemu-devel] [PATCH 0/2] s390x fixes (post 2.11) Cornelia Huck
2017-11-22 14:54 ` no-reply
2017-11-22 15:07 ` Christian Borntraeger
2017-11-22 15:45 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ca173f9-c4f3-2daa-04b0-38b4ade27504@linaro.org \
--to=richard.henderson@linaro.org \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).