From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>, qemu-devel@nongnu.org
Cc: Juan Quintela <quintela@redhat.com>,
Leonardo Bras <leobras@redhat.com>, Peter Xu <peterx@redhat.com>,
qemu-trivial@nongnu.org
Subject: Re: [PATCH 2/2] migration: unexport migrate_fd_error()
Date: Thu, 6 Jul 2023 18:44:04 +0200 [thread overview]
Message-ID: <7cc2c3da-6ec1-7c4d-0c52-8752e79064cb@linaro.org> (raw)
In-Reply-To: <20230706102937.82490-3-lersek@redhat.com>
On 6/7/23 12:29, Laszlo Ersek wrote:
> The only migrate_fd_error() call sites are in "migration/migration.c",
> which is also where we define migrate_fd_error(). Make the function
> static, and remove its declaration from "migration/migration.h".
>
> Cc: Juan Quintela <quintela@redhat.com> (maintainer:Migration)
> Cc: Leonardo Bras <leobras@redhat.com> (reviewer:Migration)
> Cc: Peter Xu <peterx@redhat.com> (reviewer:Migration)
> Cc: qemu-trivial@nongnu.org
> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2018404
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> migration/migration.h | 1 -
> migration/migration.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-07-06 16:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 10:29 [PATCH 0/2] migration: trivialities Laszlo Ersek
2023-07-06 10:29 ` [PATCH 1/2] migration: factor out "resume_requested" in qmp_migrate() Laszlo Ersek
2023-07-06 11:42 ` Juan Quintela
2023-07-06 13:28 ` Michael Tokarev
2023-07-06 14:36 ` Laszlo Ersek
2023-07-06 16:42 ` Philippe Mathieu-Daudé
2023-07-06 10:29 ` [PATCH 2/2] migration: unexport migrate_fd_error() Laszlo Ersek
2023-07-06 11:42 ` Juan Quintela
2023-07-06 16:44 ` Philippe Mathieu-Daudé [this message]
2023-07-06 12:05 ` [PATCH 0/2] migration: trivialities Peter Xu
2023-07-06 17:09 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cc2c3da-6ec1-7c4d-0c52-8752e79064cb@linaro.org \
--to=philmd@linaro.org \
--cc=leobras@redhat.com \
--cc=lersek@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).