From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47129) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIJ4t-0005QS-No for qemu-devel@nongnu.org; Tue, 06 Jun 2017 14:19:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIJ4s-0006td-M0 for qemu-devel@nongnu.org; Tue, 06 Jun 2017 14:19:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43802) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dIJ4s-0006sO-DF for qemu-devel@nongnu.org; Tue, 06 Jun 2017 14:19:38 -0400 References: <20170601130325.6433-1-marcandre.lureau@redhat.com> <20170601130325.6433-2-marcandre.lureau@redhat.com> <465a7b69-a3c0-1492-8e30-c562a76cd65a@redhat.com> <0a434f41-1131-713d-1fc9-a9edba425f7a@redhat.com> <584abbba-669d-0fac-2144-5f7010b1a7ae@redhat.com> <671cbc52-dfa5-38a3-e4a8-73152af4bada@cn.fujitsu.com> From: Laszlo Ersek Message-ID: <7cc65152-169e-0e9c-c015-edb8a4d7e82b@redhat.com> Date: Tue, 6 Jun 2017 20:19:34 +0200 MIME-Version: 1.0 In-Reply-To: <671cbc52-dfa5-38a3-e4a8-73152af4bada@cn.fujitsu.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 1/4] dump: add DumpInfo structure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhang Chen , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Eric Blake , qemu-devel@nongnu.org, "wencongyang2@huawei.com" Cc: anderson@redhat.com, qiaonuohan On 06/04/17 17:56, Zhang Chen wrote: >=20 >=20 > On 06/03/2017 06:49 AM, Laszlo Ersek wrote: >> On 06/02/17 11:55, Marc-Andr=C3=A9 Lureau wrote: >>> Hi >>> >>> On Fri, Jun 2, 2017 at 1:46 PM Marc-Andr=C3=A9 Lureau >>> >>> wrote: >>> >>>> Hi >>>> >>>> On Thu, Jun 1, 2017 at 10:19 PM Eric Blake wrote= : >>>> >>>>> On 06/01/2017 01:06 PM, Laszlo Ersek wrote: >>>>>> On 06/01/17 15:03, Marc-Andr=C3=A9 Lureau wrote: >>>>>>> One way or another, the guest could communicate various dump info >>>>>>> (via >>>>>>> guest agent or vmcoreinfo device) and populate that structure. It >>>>>>> can >>>>>>> then be used to augment the dump with various details, as done in >>>>>>> the >>>>>>> following patch. >>>>>>> >>>>>>> Signed-off-by: Marc-Andr=C3=A9 Lureau >>>>>>> --- >>>>>>> include/sysemu/dump-info.h | 18 ++++++++++++++++++ >>>>>>> dump.c | 3 +++ >>>>>>> 2 files changed, 21 insertions(+) >>>>>>> create mode 100644 include/sysemu/dump-info.h >>>>>>> >>>>>>> diff --git a/include/sysemu/dump-info.h b/include/sysemu/dump-inf= o.h >>>>>>> new file mode 100644 >>>>>>> index 0000000000..d2378e15e2 >>>>>>> --- /dev/null >>>>>>> +++ b/include/sysemu/dump-info.h >>>>>>> @@ -0,0 +1,18 @@ >>>>>>> +#ifndef DUMP_INFO_H >>>>>>> +#define DUMP_INFO_H >>>>>> Can you please spell out, in the commit message, the reason for >>>>>> introducing a new header file? (I suspect your reason, but it >>>>>> should be >>>>>> documented explicitly.) >>>>> Also, should you have a copyright header in the new file? And does >>>>> MAINTAINERS cover it? >>>>> >>>> None of the dump support is covered. Based on commit history, I can >>>> suggest Wen Congyang, as original author. >>>> Sadly, Qiao Nuohan cannot be reached with his mail today (anyone >>>> knows if >>>> he is still contributing?). Laszlo has done significant changes and >>>> reviews >>>> too. I can also propose myself to help with reviews. >>>> >>>> Wen or Laszla, do you want to be the main maintainer? >=20 > I can cc Qiao Nuohan... That would be great, thanks! Laszlo >=20 > Thanks > Zhang Chen >=20 >>>> >>> (sorry for the typo) >>> >>> or rather "Supported" ("Someone is actually paid to look after this" >>> according to MAINTAINERS) >>> >> Thanks, but I don't wish to have an official responsibility for this >> feature. My current responsibilities are more than enough to keep me >> busy. >> >> If you'd like to volunteer for maintaining the dump stuff, you have my >> blessing of course (whatever weight that might carry). >> >> Thanks >> Laszlo >> >> >> >> >=20