From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C716C04AA7 for ; Mon, 13 May 2019 13:55:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 421E6208CA for ; Mon, 13 May 2019 13:55:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 421E6208CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:57763 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQBQq-0007Eq-F7 for qemu-devel@archiver.kernel.org; Mon, 13 May 2019 09:55:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59842) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQBM7-0003HA-JC for qemu-devel@nongnu.org; Mon, 13 May 2019 09:51:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQBDI-00039M-8m for qemu-devel@nongnu.org; Mon, 13 May 2019 09:41:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58480) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hQBDG-00038a-Tv; Mon, 13 May 2019 09:41:55 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2D0B13082206; Mon, 13 May 2019 13:41:54 +0000 (UTC) Received: from dresden.str.redhat.com (unknown [10.40.206.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B7CE05C225; Mon, 13 May 2019 13:41:49 +0000 (UTC) To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, qemu-block@nongnu.org References: <20190429090842.57910-1-vsementsov@virtuozzo.com> From: Max Reitz Openpgp: preference=signencrypt Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: <7cdffa69-0358-9819-0bf8-aff9546a3991@redhat.com> Date: Mon, 13 May 2019 15:41:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190429090842.57910-1-vsementsov@virtuozzo.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1tiqQSVnAhC9wPV5KDFIMtX44nmaRIHUU" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Mon, 13 May 2019 13:41:54 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [Qemu-devel] [PATCH v7 0/5] backup-top: preparing refactoring X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, den@openvz.org, jsnow@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1tiqQSVnAhC9wPV5KDFIMtX44nmaRIHUU From: Max Reitz To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: kwolf@redhat.com, jsnow@redhat.com, den@openvz.org Message-ID: <7cdffa69-0358-9819-0bf8-aff9546a3991@redhat.com> Subject: Re: [PATCH v7 0/5] backup-top: preparing refactoring References: <20190429090842.57910-1-vsementsov@virtuozzo.com> In-Reply-To: <20190429090842.57910-1-vsementsov@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 29.04.19 11:08, Vladimir Sementsov-Ogievskiy wrote: > Hi all! >=20 > Here some refactoring patches, as a first step for backup-top filter > introduction. >=20 > v7: > 01,03,04: add Max's r-b > 05: fix s/return NULL/goto error/ [Max] >=20 > v6: > 01: - use end_cluster instead of last_cluster and fix bug in > calculation [Max] > 02: only rebased on 01, keep r-b > 03, 04: new > 05: it's rewritten > "[PATCH v5 10/11] block/backup: tiny refactor backup_job_create", > to make it more useful in general than just code movement inside > one function >=20 > Vladimir Sementsov-Ogievskiy (5): > block/backup: simplify backup_incremental_init_copy_bitmap > block/backup: move to copy_bitmap with granularity > block/backup: refactor and tolerate unallocated cluster skipping > block/backup: unify different modes code path > block/backup: refactor: split out backup_calculate_cluster_size >=20 > block/backup.c | 243 +++++++++++++++++++++----------------------------= > 1 file changed, 105 insertions(+), 138 deletions(-) Thanks, I=E2=80=99ve fixed patch 5=E2=80=99s commit message and applied t= he series to my block branch: https://git.xanclic.moe/XanClic/qemu/commits/branch/block Max --1tiqQSVnAhC9wPV5KDFIMtX44nmaRIHUU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAlzZdBwACgkQ9AfbAGHV z0APDwgAh6f54llRy8fVhgxj6x482xQP+N4+tyn0Xgslp8MbrnIHbgekDHFpOZu7 9PQb1/bKSV1oyrP2p3TB6EGvwlC7JzDSOwfUYUJdTXS83sxDkRoCBSnmXPVCTUta /SorWM0baUxEnty+02l/EDe/Pa1bG1uz9g30cYxxs8Wf7ix9W+lwa6rnOjU5FHN4 wZTUa25RQ9KmuYCJUlxj91tSqzzzrKg6Xj0cPGxWBU0VSA27USbjLedYmxkOcGHK DvaLfH9vEWTKK+lJzXcHR14dL9gFZMmX40qUToeImz0Oin9uvq68XCChmxKoQ0n6 vw4rjhh2Z91V2K4c+8/R/ncIo4Thcg== =vF9J -----END PGP SIGNATURE----- --1tiqQSVnAhC9wPV5KDFIMtX44nmaRIHUU--