From: Laurent Vivier <laurent@vivier.eu>
To: Kamil Rytarowski <n54@gmx.com>
Cc: qemu-devel@nongnu.org, f4bug@amsat.org, peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH v4] target/m68k: Switch fpu_rom from make_floatx80() to make_floatx80_init()
Date: Mon, 4 Sep 2017 23:44:53 +0200 [thread overview]
Message-ID: <7cf547d4-e850-c5ec-2afa-2d699e1c0aa9@vivier.eu> (raw)
In-Reply-To: <20170904212306.3020-1-n54@gmx.com>
Le 04/09/2017 à 23:23, Kamil Rytarowski a écrit :
> GCC 4.7.2 on SunOS reports that the values assigned to array members are not
> real constants:
>
> target/m68k/fpu_helper.c:32:5: error: initializer element is not constant
> target/m68k/fpu_helper.c:32:5: error: (near initialization for 'fpu_rom[0]')
> rules.mak:66: recipe for target 'target/m68k/fpu_helper.o' failed
>
> Convert the array to make_floatx80_init() to fix it.
> Replace floatx80_pi-like constants with make_floatx80_init() as they are
> defined as make_floatx80().
>
> This fixes build on SmartOS (Joyent).
>
> Signed-off-by: Kamil Rytarowski <n54@gmx.com>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/m68k/fpu_helper.c | 44 ++++++++++++++++++++++----------------------
> 1 file changed, 22 insertions(+), 22 deletions(-)
>
Applied to my branch m68k-for-2.11
Thanks,
Laurent
prev parent reply other threads:[~2017-09-04 21:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-03 16:31 [Qemu-devel] [PATCH] target/m68k: Change fpu_rom from const static array to switch Kamil Rytarowski
2017-09-03 17:05 ` Laurent Vivier
2017-09-04 0:27 ` Philippe Mathieu-Daudé
2017-09-04 13:54 ` Kamil Rytarowski
2017-09-04 14:09 ` Laurent Vivier
2017-09-04 14:41 ` Philippe Mathieu-Daudé
2017-09-04 14:53 ` Kamil Rytarowski
2017-09-04 15:02 ` Peter Maydell
2017-09-04 15:16 ` Kamil Rytarowski
2017-09-04 15:53 ` Laurent Vivier
2017-09-04 16:17 ` Peter Maydell
2017-09-04 16:38 ` Kamil Rytarowski
2017-09-04 16:38 ` Laurent Vivier
2017-09-04 16:40 ` Peter Maydell
2017-09-04 8:00 ` no-reply
2017-09-04 16:46 ` [Qemu-devel] [PATCH v2] target/m68k: Switch fpu_rom from make_floatx80() to make_floatx80_init() Kamil Rytarowski
2017-09-04 17:16 ` Philippe Mathieu-Daudé
2017-09-04 17:23 ` Laurent Vivier
2017-09-04 18:01 ` Philippe Mathieu-Daudé
2017-09-04 17:32 ` [Qemu-devel] [PATCH v3] " Kamil Rytarowski
2017-09-04 19:02 ` Laurent Vivier
2017-09-04 21:38 ` Kamil Rytarowski
2017-09-04 21:23 ` [Qemu-devel] [PATCH v4] " Kamil Rytarowski
2017-09-04 21:44 ` Laurent Vivier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cf547d4-e850-c5ec-2afa-2d699e1c0aa9@vivier.eu \
--to=laurent@vivier.eu \
--cc=f4bug@amsat.org \
--cc=n54@gmx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).