qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: Alex Williamson <alex.williamson@redhat.com>,
	Zhenzhong Duan <zhenzhong.duan@intel.com>,
	Eric Auger <eric.auger@redhat.com>,
	qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [PULL 05/12] vfio/iommufd: Fix SIGSEV in iommufd_cdev_attach()
Date: Thu, 13 Feb 2025 07:32:05 +0100	[thread overview]
Message-ID: <7d076159-d3c9-4b38-bb8c-40645098e28a@redhat.com> (raw)
In-Reply-To: <9c31241e-96d0-4014-b9ce-42362ea10eaf@tls.msk.ru>

On 2/12/25 20:12, Michael Tokarev wrote:
> 11.02.2025 17:33, Cédric Le Goater wrote:
>> From: Zhenzhong Duan <zhenzhong.duan@intel.com>
>>
>> When iommufd_cdev_ram_block_discard_disable() fails for whatever reason,
>> errp should be set or else SIGSEV is triggered in vfio_realize() when
>> error_prepend() is called.
>>
>> By this chance, use the same error message for both legacy and iommufd
>> backend.
>>
>> Fixes: 5ee3dc7af785 ("vfio/iommufd: Implement the iommufd backend")
>> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
>> Reviewed-by: Eric Auger <eric.auger@redhat.com>
>> Link: https://lore.kernel.org/r/20250116102307.260849-1-zhenzhong.duan@intel.com
>> Signed-off-by: Cédric Le Goater <clg@redhat.com>
>> ---
>>   hw/vfio/iommufd.c | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> This seems to be a qemu-stable material (for 9.2).
> Please let me know if it is not.

For 9.0 and above. It applies cleanly.

Thanks,

C.





  reply	other threads:[~2025-02-13  6:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-11 14:33 [PULL 00/12] vfio queue Cédric Le Goater
2025-02-11 14:33 ` [PULL 01/12] vfio/igd: Fix potential overflow in igd_gtt_memory_size() Cédric Le Goater
2025-02-11 14:33 ` [PULL 02/12] vfio/pci: declare generic quirks in a new header file Cédric Le Goater
2025-02-11 14:33 ` [PULL 03/12] vfio/pci: introduce config_offset field in VFIOConfigMirrorQuirk Cédric Le Goater
2025-02-11 14:33 ` [PULL 04/12] vfio/igd: use VFIOConfigMirrorQuirk for mirrored registers Cédric Le Goater
2025-02-11 14:33 ` [PULL 05/12] vfio/iommufd: Fix SIGSEV in iommufd_cdev_attach() Cédric Le Goater
2025-02-12 19:12   ` Michael Tokarev
2025-02-13  6:32     ` Cédric Le Goater [this message]
2025-02-13  6:42       ` Michael Tokarev
2025-02-13  8:48         ` Cédric Le Goater
2025-02-13  9:30           ` Michael Tokarev
2025-02-11 14:33 ` [PULL 06/12] util/error: Introduce warn_report_err_once() Cédric Le Goater
2025-02-11 14:33 ` [PULL 07/12] vfio/pci: Replace "iommu_device" by "vIOMMU" Cédric Le Goater
2025-02-11 14:33 ` [PULL 08/12] vfio: Rephrase comment in vfio_listener_region_add() error path Cédric Le Goater
2025-02-11 14:33 ` [PULL 09/12] vfio: Introduce vfio_get_vfio_device() Cédric Le Goater
2025-02-11 14:33 ` [PULL 10/12] vfio: Improve error reporting when MMIO region mapping fails Cédric Le Goater
2025-02-11 14:33 ` [PULL 11/12] vfio: Remove reports of DMA mapping errors in backends Cédric Le Goater
2025-02-11 14:33 ` [PULL 12/12] vfio: Remove superfluous error report in vfio_listener_region_add() Cédric Le Goater
2025-02-12 17:38 ` [PULL 00/12] vfio queue Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d076159-d3c9-4b38-bb8c-40645098e28a@redhat.com \
    --to=clg@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=zhenzhong.duan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).