From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Pierrick Bouvier <pierrick.bouvier@linaro.org>,
qemu-devel@nongnu.org, Basil Salman <bsalman@redhat.com>
Cc: sw@weilnetz.de, kkostiuk@redhat.com, clg@kaod.org,
richard.henderson@linaro.org, alex.bennee@linaro.org,
peter.maydell@linaro.org
Subject: Re: [PATCH v2 3/4] qga/vss-win32: fix warning for clang++-15
Date: Mon, 20 Feb 2023 20:30:22 +0100 [thread overview]
Message-ID: <7d1224f9-d83a-59f6-8577-f942e399502c@linaro.org> (raw)
In-Reply-To: <20230216134911.6803-4-pierrick.bouvier@linaro.org>
On 16/2/23 14:49, Pierrick Bouvier wrote:
> Reported when compiling with clang-windows-arm64.
>
> ../qga/vss-win32/install.cpp:537:9: error: variable 'hr' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
> if (!(ControlService(service, SERVICE_CONTROL_STOP, NULL))) {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../qga/vss-win32/install.cpp:545:12: note: uninitialized use occurs here
> return hr;
> ^~
Fixes: 917ebcb170 ("qga-win: Fix QGA VSS Provider service stop failure")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
(please also carry the 'Fixes:' tags when respining patches)
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
> qga/vss-win32/install.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp
> index b57508fbe0..b8087e5baa 100644
> --- a/qga/vss-win32/install.cpp
> +++ b/qga/vss-win32/install.cpp
> @@ -518,7 +518,7 @@ namespace _com_util
> /* Stop QGA VSS provider service using Winsvc API */
> STDAPI StopService(void)
> {
> - HRESULT hr;
> + HRESULT hr = S_OK;
> SC_HANDLE manager = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS);
> SC_HANDLE service = NULL;
>
next prev parent reply other threads:[~2023-02-20 19:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 13:49 [PATCH v2 0/4] Adds support for running QEMU natively on windows-arm64 Pierrick Bouvier
2023-02-16 13:49 ` [PATCH v2 1/4] util/cacheflush: fix cache " Pierrick Bouvier
2023-02-16 19:42 ` Richard Henderson
2023-03-01 17:27 ` Pierrick Bouvier
2023-02-17 15:32 ` Peter Maydell
2023-02-20 9:58 ` Pierrick Bouvier
2023-02-16 13:49 ` [PATCH v2 2/4] sysemu/os-win32: fix setjmp/longjmp " Pierrick Bouvier
2023-02-16 20:02 ` Richard Henderson
2023-02-20 9:53 ` Pierrick Bouvier
2023-02-20 17:50 ` Richard Henderson
2023-02-16 13:49 ` [PATCH v2 3/4] qga/vss-win32: fix warning for clang++-15 Pierrick Bouvier
2023-02-20 19:30 ` Philippe Mathieu-Daudé [this message]
2023-02-21 9:42 ` Pierrick Bouvier
2023-02-16 13:49 ` [PATCH v2 4/4] target/ppc: fix warning with clang-15 Pierrick Bouvier
2023-02-16 20:11 ` Richard Henderson
2023-02-17 17:23 ` Philippe Mathieu-Daudé
2023-02-20 9:56 ` Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d1224f9-d83a-59f6-8577-f942e399502c@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=bsalman@redhat.com \
--cc=clg@kaod.org \
--cc=kkostiuk@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).