From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1euOIK-0003JR-NF for qemu-devel@nongnu.org; Fri, 09 Mar 2018 15:07:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1euOIJ-0006av-Un for qemu-devel@nongnu.org; Fri, 09 Mar 2018 15:07:12 -0500 References: <20180309172713.26318-1-kwolf@redhat.com> <20180309172713.26318-3-kwolf@redhat.com> From: Eric Blake Message-ID: <7d16f763-a8fe-7e0f-9bbf-7ec5b51d6222@redhat.com> Date: Fri, 9 Mar 2018 14:06:47 -0600 MIME-Version: 1.0 In-Reply-To: <20180309172713.26318-3-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/6] luks: Create block_crypto_co_create_generic() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: mreitz@redhat.com, berrange@redhat.com, qemu-devel@nongnu.org On 03/09/2018 11:27 AM, Kevin Wolf wrote: > Everything that refers to the protocol layer or QemuOpts is moved out of > block_crypto_create_generic(), so that the remaining function is > suitable to be called by a .bdrv_co_create implementation. > > LUKS is the only driver that actually implements the old interface, and > we don't intend to use it in any new drivers, so put the moved out code > directly into a LUKS function rather than creating a generic > intermediate one. > > Signed-off-by: Kevin Wolf > --- > block/crypto.c | 95 +++++++++++++++++++++++++++++++++++++--------------------- > 1 file changed, 61 insertions(+), 34 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org