From: Laurent Vivier <lvivier@redhat.com>
To: Li Qiang <liq3ea@gmail.com>,
stefanha@redhat.com, marcandre.lureau@redhat.com,
thuth@redhat.com
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hw: set_netdev: remove useless code
Date: Fri, 9 Nov 2018 09:21:19 +0100 [thread overview]
Message-ID: <7d20734d-f43a-957c-9cb5-4644320037aa@redhat.com> (raw)
In-Reply-To: <1541751214-17515-1-git-send-email-liq3ea@gmail.com>
On 09/11/2018 09:13, Li Qiang wrote:
> In set_netdev(), the peers[i] is initialized
> qemu_find_net_clients_except() when i is in
> 0 between 'queues' it can't be NULL.
>
> Signed-off-by: Li Qiang <liq3ea@gmail.com>
> ---
> hw/core/qdev-properties-system.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c
> index 8b22fb5..b45a7ef 100644
> --- a/hw/core/qdev-properties-system.c
> +++ b/hw/core/qdev-properties-system.c
> @@ -288,10 +288,6 @@ static void set_netdev(Object *obj, Visitor *v, const char *name,
> }
>
> for (i = 0; i < queues; i++) {
> - if (peers[i] == NULL) {
> - err = -ENOENT;
> - goto out;
> - }
>
> if (peers[i]->peer) {
> err = -EEXIST;
>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
next prev parent reply other threads:[~2018-11-09 8:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 8:13 [Qemu-devel] [PATCH] hw: set_netdev: remove useless code Li Qiang
2018-11-09 8:21 ` Laurent Vivier [this message]
2018-11-09 8:26 ` Thomas Huth
2018-11-09 8:29 ` Laurent Vivier
2018-11-09 10:00 ` Paolo Bonzini
2018-11-09 10:59 ` Laurent Vivier
2018-11-12 8:59 ` [Qemu-devel] qdev has no maintainer (was: [PATCH] hw: set_netdev: remove useless code) Markus Armbruster
2018-11-09 9:07 ` [Qemu-devel] [PATCH] hw: set_netdev: remove useless code Thomas Huth
2018-11-09 9:25 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d20734d-f43a-957c-9cb5-4644320037aa@redhat.com \
--to=lvivier@redhat.com \
--cc=liq3ea@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).