Re: [PATCH v2 05/11] target/riscv: Convert misa_mxl_max using GLib macros

[Richard Henderson <richard.henderson@linaro.org>]

On 2/10/25 05:31, Philippe Mathieu-Daudé wrote:
> Use GLib conversion macros to pass misa_mxl_max as
> riscv_cpu_class_init() class data.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> Cc: qemu-riscv@nongnu.org
> ---
>   target/riscv/cpu.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index f3ad7f88f0e..9fe1b23a297 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -2955,7 +2955,7 @@ static void riscv_cpu_class_init(ObjectClass *c, void *data)
>   {
>       RISCVCPUClass *mcc = RISCV_CPU_CLASS(c);
>   
> -    mcc->misa_mxl_max = (RISCVMXL)(uintptr_t)data;
> +    mcc->misa_mxl_max = (RISCVMXL)GPOINTER_TO_UINT(data);
>       riscv_cpu_validate_misa_mxl(mcc);
>   }

I guess this is quite a bit more explicit about what's going on.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~