From: Laurent Vivier <laurent@vivier.eu>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Yoni Bettan <ybettan@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Riku Voipio <riku.voipio@iki.fi>
Subject: Re: [Qemu-devel] [PATCH] vl.c && linux-user/main.c : removed **envp from main() arguments
Date: Mon, 18 Dec 2017 15:07:26 +0100 [thread overview]
Message-ID: <7d655b6e-22a7-eb24-f8ba-4ed817e4aa71@vivier.eu> (raw)
In-Reply-To: <CAFEAcA93oFez4Fvz83vye3-JjWFLMNyLKA3UL+Pck8d6eNWRaw@mail.gmail.com>
Le 18/12/2017 à 13:30, Peter Maydell a écrit :
> On 18 December 2017 at 07:52, Laurent Vivier <laurent@vivier.eu> wrote:
>> I think we don't need it anymore as there is no difference betweent
>> qemu_main() and main().
>
> You need to be a bit cautious there to avoid breaking
> the OSX code in ui/cocoa.m, which has its own version
> of main() which kicks off the GUI code and then eventually
> calls qemu_main() later.
Yes, you're right. cocoa.m needs qemu_main() because there is already a
main() inside. So we can't remove qemu_main().
Thanks,
Laurent
prev parent reply other threads:[~2017-12-18 14:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 6:41 [Qemu-devel] [PATCH] vl.c && linux-user/main.c : removed **envp from main() arguments Yoni Bettan
2017-11-21 6:46 ` no-reply
2017-11-21 7:30 ` Laurent Vivier
2017-12-18 6:07 ` Yoni Bettan
2017-12-18 7:52 ` Laurent Vivier
2017-12-18 12:30 ` Peter Maydell
2017-12-18 14:07 ` Laurent Vivier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d655b6e-22a7-eb24-f8ba-4ed817e4aa71@vivier.eu \
--to=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=ybettan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).