From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Anton Johansson <anjo@rev.ng>,
Alistair Francis <alistair@alistair23.me>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [PATCH 2/5] target/microblaze: Remove target_ulong uses in get_phys_page_attrs_debug
Date: Wed, 8 Oct 2025 10:30:25 -0700 [thread overview]
Message-ID: <7d705ff4-587f-41d1-8f39-e8190ce8547c@linaro.org> (raw)
In-Reply-To: <20251008060129.87579-3-philmd@linaro.org>
On 10/7/25 11:01 PM, Philippe Mathieu-Daudé wrote:
> The CPUClass::get_phys_page_debug() handler takes a 'vaddr' address
> and return a 'hwaddr' type since commit 00b941e581b ("cpu: Turn
> cpu_get_phys_page_debug() into a CPUClass hook").
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/microblaze/helper.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/target/microblaze/helper.c b/target/microblaze/helper.c
> index ef0e2f973fa..cf577a72268 100644
> --- a/target/microblaze/helper.c
> +++ b/target/microblaze/helper.c
> @@ -274,7 +274,8 @@ hwaddr mb_cpu_get_phys_page_attrs_debug(CPUState *cs, vaddr addr,
> MemTxAttrs *attrs)
> {
> MicroBlazeCPU *cpu = MICROBLAZE_CPU(cs);
> - target_ulong vaddr, paddr = 0;
> + vaddr vaddr;
> + hwaddr paddr = 0;
> MicroBlazeMMULookup lu;
> int mmu_idx = cpu_mmu_index(cs, false);
> unsigned int hit;
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
next prev parent reply other threads:[~2025-10-08 17:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-08 6:01 [PATCH 0/5] target/microblaze: Remove all uses of target_ulong type Philippe Mathieu-Daudé
2025-10-08 6:01 ` [PATCH 1/5] target/microblaze: Remove target_ulong use in cpu_handle_mmu_fault() Philippe Mathieu-Daudé
2025-10-08 10:04 ` Anton Johansson via
2025-10-08 17:30 ` Pierrick Bouvier
2025-10-08 6:01 ` [PATCH 2/5] target/microblaze: Remove target_ulong uses in get_phys_page_attrs_debug Philippe Mathieu-Daudé
2025-10-08 17:30 ` Pierrick Bouvier [this message]
2025-10-08 6:01 ` [PATCH 3/5] target/microblaze: Remove target_ulong use in gen_goto_tb() Philippe Mathieu-Daudé
2025-10-08 10:07 ` Anton Johansson via
2025-10-08 17:31 ` Pierrick Bouvier
2025-10-08 6:01 ` [PATCH 4/5] target/microblaze: Remove target_ulong use in helper_stackprot() Philippe Mathieu-Daudé
2025-10-08 10:22 ` Anton Johansson via
2025-10-08 17:31 ` Pierrick Bouvier
2025-10-08 6:01 ` [PATCH 5/5] target/microblaze: Convert CPUMBState::res_addr field to uint32_t type Philippe Mathieu-Daudé
2025-10-08 10:23 ` Anton Johansson via
2025-10-08 17:31 ` Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d705ff4-587f-41d1-8f39-e8190ce8547c@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=alistair@alistair23.me \
--cc=anjo@rev.ng \
--cc=edgar.iglesias@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).