From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E5B4C433B4 for ; Thu, 22 Apr 2021 14:40:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D58366142F for ; Thu, 22 Apr 2021 14:40:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D58366142F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41518 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZaUp-0001xK-Ey for qemu-devel@archiver.kernel.org; Thu, 22 Apr 2021 10:39:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56514) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZaU0-0001Wr-I1 for qemu-devel@nongnu.org; Thu, 22 Apr 2021 10:39:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:38771) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZaTy-0006tw-MS for qemu-devel@nongnu.org; Thu, 22 Apr 2021 10:39:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619102346; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0RJTbDtwlf71D7eCU2lIw1X2uccqT5ExpbqT11UGSy8=; b=Bx+FXV7aNR9XplCCg6XNV5A+oGJHtLJUGYjbXrJHvlcnygZKZrkVmr1XYjLYfgwzrzV5yu V/UL18/QE05Te8Uz9xfhAAH/zwD7Hb1X7bMG0kY4eyREVmp3dw/yp0nvLsUzcwlRMuibFC k4zaklBI47ab5MVxqGjnCOSfjyXWvz8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-328-sXNaxK0DOHS_rNCug1XboQ-1; Thu, 22 Apr 2021 10:38:53 -0400 X-MC-Unique: sXNaxK0DOHS_rNCug1XboQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 75D5918D0EE8; Thu, 22 Apr 2021 14:38:52 +0000 (UTC) Received: from [10.10.118.152] (ovpn-118-152.rdu2.redhat.com [10.10.118.152]) by smtp.corp.redhat.com (Postfix) with ESMTP id B9C5860613; Thu, 22 Apr 2021 14:38:51 +0000 (UTC) Subject: Re: [PATCH v3 0/8] qapi: static typing conversion, pt4 To: Markus Armbruster References: <20210421192233.3542904-1-jsnow@redhat.com> <87k0ouyc3j.fsf@dusky.pond.sub.org> From: John Snow Message-ID: <7d8e4485-95e3-1408-2670-e16d5193a690@redhat.com> Date: Thu, 22 Apr 2021 10:38:51 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <87k0ouyc3j.fsf@dusky.pond.sub.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Cleber Rosa , qemu-devel@nongnu.org, Michael Roth , Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/22/21 4:09 AM, Markus Armbruster wrote: > John Snow writes: > >> Hi, this series adds static type hints to the QAPI module. >> This is part four, and focuses on error.py. >> >> Part 4: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt4 >> CI: https://gitlab.com/jsnow/qemu/-/pipelines/290152364 >> >> Requirements: >> - Python 3.6+ >> - mypy >= 0.770 >> - pylint >= 2.6.0 (2.7.0+ when using Python 3.9+) >> >> Every commit should pass with: >> - `isort -c qapi/` >> - `flake8 qapi/` >> - `pylint --rcfile=qapi/pylintrc qapi/` >> - `mypy --config-file=qapi/mypy.ini qapi/` > > I doubt PATCH 1 is worth the trouble without an actual concrete > location-less error. However, arguing about it some more would also not > worth the trouble, so: > > Reviewed-by: Markus Armbruster > > and queued. Thanks! > FWIW, I use it a few times in Part 5a: - Once in main.py, to wrap an OSError (You'll see why) - Again in qapidoc to create a "QAPIDocError" class, but this is only used in PoC code to demonstrate that QAPISchemaParser is fully typed. I am finding it handy, though it may be true we wind up not needing it, based on reviews in part 5. Thanks for queueing it up! --js (Why does tbird spellcheck not think 'queueing' is a word?)