From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45105)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ayiwd-0003e4-LN
	for qemu-devel@nongnu.org; Fri, 06 May 2016 12:49:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ayiwS-0003oO-1w
	for qemu-devel@nongnu.org; Fri, 06 May 2016 12:49:34 -0400
Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:36271)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ayiwQ-0003jp-Ns
	for qemu-devel@nongnu.org; Fri, 06 May 2016 12:49:27 -0400
Received: by mail-qk0-x242.google.com with SMTP id l68so7595312qkf.3
	for <qemu-devel@nongnu.org>; Fri, 06 May 2016 09:49:12 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1462392752-17703-1-git-send-email-laurent@vivier.eu>
	<1462392752-17703-19-git-send-email-laurent@vivier.eu>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <7d8e94be-f15f-a670-e128-7c0a08a2882b@twiddle.net>
Date: Fri, 6 May 2016 06:49:03 -1000
MIME-Version: 1.0
In-Reply-To: <1462392752-17703-19-git-send-email-laurent@vivier.eu>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 18/52] target-m68k: Some fixes to SR and
 flags management
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: gerg@uclinux.org, schwab@linux-m68k.org, agraf@suse.de

On 05/04/2016 10:11 AM, Laurent Vivier wrote:
> -uint32_t cpu_m68k_flush_flags(CPUM68KState *env, int op)
> +static uint32_t cpu_m68k_flush_flags(CPUM68KState *env, int op)
>  {
>      int flags;
>      uint32_t src;
> @@ -271,6 +271,18 @@ set_x:
>      return flags;
>  }
>
> +uint32_t cpu_m68k_get_ccr(CPUM68KState *env)
> +{
> +    return cpu_m68k_flush_flags(env, env->cc_op) | env->cc_x * CCF_X;
> +}

This probably ought to get squished into the previous, to avoid thrashing.


r~