Re: [RFC PATCH v4 04/30] target/loongarch: Implement qmp_query_cpu_definitions()

[WANG Xuerui <i.qemu@xen0n.name>]

On 1/8/22 17:13, Xiaojuan Yang wrote:
> This patch introduce qmp_query_cpu_definitions interface.

"implments"; however the whole sentence becomes nearly identical to the 
title, so it's better to remove this sentence after all.

> Signed-off-by: Xiaojuan Yang<yangxiaojuan@loongson.cn>
> Signed-off-by: Song Gao<gaosong@loongson.cn>
> Reviewed-by: Richard Henderson<richard.henderson@linaro.org>
> ---
>   qapi/machine-target.json |  6 ++++--
>   target/loongarch/cpu.c   | 26 ++++++++++++++++++++++++++
>   2 files changed, 30 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/machine-target.json b/qapi/machine-target.json
> index f5ec4bc172..682dc86b42 100644
> --- a/qapi/machine-target.json
> +++ b/qapi/machine-target.json
> @@ -324,7 +324,8 @@
>                      'TARGET_ARM',
>                      'TARGET_I386',
>                      'TARGET_S390X',
> -                   'TARGET_MIPS' ] } }
> +                   'TARGET_MIPS',
> +                   'TARGET_LOONGARCH64' ] } }
>   
>   ##
>   # @query-cpu-definitions:
> @@ -340,4 +341,5 @@
>                      'TARGET_ARM',
>                      'TARGET_I386',
>                      'TARGET_S390X',
> -                   'TARGET_MIPS' ] } }
> +                   'TARGET_MIPS',
> +                   'TARGET_LOONGARCH64' ] } }
> diff --git a/target/loongarch/cpu.c b/target/loongarch/cpu.c
> index 6e3dc5e6fa..690eeea2e6 100644
> --- a/target/loongarch/cpu.c
> +++ b/target/loongarch/cpu.c
> @@ -351,3 +351,29 @@ static const TypeInfo loongarch_cpu_type_infos[] = {
>   };
>   
>   DEFINE_TYPES(loongarch_cpu_type_infos)
> +
> +static void loongarch_cpu_add_definition(gpointer data, gpointer user_data)
> +{
> +    ObjectClass *oc = data;
> +    CpuDefinitionInfoList **cpu_list = user_data;
> +    CpuDefinitionInfo *info = g_new0(CpuDefinitionInfo, 1);
> +    const char *typename = object_class_get_name(oc);
> +
> +    info->name = g_strndup(typename,
> +                           strlen(typename) - strlen("-" TYPE_LOONGARCH_CPU));
> +    info->q_typename = g_strdup(typename);
> +
> +    QAPI_LIST_PREPEND(*cpu_list, info);
> +}
> +
> +CpuDefinitionInfoList *qmp_query_cpu_definitions(Error **errp)
> +{
> +    CpuDefinitionInfoList *cpu_list = NULL;
> +    GSList *list;
> +
> +    list = object_class_get_list(TYPE_LOONGARCH_CPU, false);
> +    g_slist_foreach(list, loongarch_cpu_add_definition, &cpu_list);
> +    g_slist_free(list);
> +
> +    return cpu_list;
> +}

After removing the commit message body:

Reviewed-by: WANG Xuerui <git@xen0n.name>