From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3381EC433E0 for ; Wed, 10 Jun 2020 17:34:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08C43206F4 for ; Wed, 10 Jun 2020 17:34:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08C43206F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33948 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj4c5-00025Y-AZ for qemu-devel@archiver.kernel.org; Wed, 10 Jun 2020 13:34:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59146) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj4bN-0001Cq-Tk for qemu-devel@nongnu.org; Wed, 10 Jun 2020 13:33:25 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:46363) by eggs.gnu.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj4bM-000367-Ra for qemu-devel@nongnu.org; Wed, 10 Jun 2020 13:33:25 -0400 Received: from [192.168.100.1] ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue010 [213.165.67.103]) with ESMTPSA (Nemesis) id 1MK3BO-1jVOGP1yQQ-00LV5i; Wed, 10 Jun 2020 19:33:19 +0200 Subject: Re: [PATCH v2 1/6] linux-user: Extend strace support to enable argument printing after syscall execution To: Filip Bozuta , qemu-devel@nongnu.org References: <20200608164357.25065-1-filip.bozuta@syrmia.com> <20200608164357.25065-2-filip.bozuta@syrmia.com> From: Laurent Vivier Autocrypt: addr=laurent@vivier.eu; prefer-encrypt=mutual; keydata= mQINBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABtCJMYXVyZW50IFZp dmllciA8bGF1cmVudEB2aXZpZXIuZXU+iQI4BBMBAgAiBQJWBTDeAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAAKCRDzDDi9Py++PCEdD/oD8LD5UWxhQrMQCsUgLlXCSM7sxGLkwmmF ozqSSljEGRhffxZvO35wMFcdX9Z0QOabVoFTKrT04YmvbjsErh/dP5zeM/4EhUByeOS7s6Yl HubMXVQTkak9Wa9Eq6irYC6L41QNzz/oTwNEqL1weV1+XC3TNnht9B76lIaELyrJvRfgsp9M rE+PzGPo5h7QHWdL/Cmu8yOtPLa8Y6l/ywEJ040IoiAUfzRoaJs2csMXf0eU6gVBhCJ4bs91 jtWTXhkzdl4tdV+NOwj3j0ukPy+RjqeL2Ej+bomnPTOW8nAZ32dapmu7Fj7VApuQO/BSIHyO NkowMMjB46yohEepJaJZkcgseaus0x960c4ua/SUm/Nm6vioRsxyUmWd2nG0m089pp8LPopq WfAk1l4GciiMepp1Cxn7cnn1kmG6fhzedXZ/8FzsKjvx/aVeZwoEmucA42uGJ3Vk9TiVdZes lqMITkHqDIpHjC79xzlWkXOsDbA2UY/P18AtgJEZQPXbcrRBtdSifCuXdDfHvI+3exIdTpvj BfbgZAar8x+lcsQBugvktlQWPfAXZu4Shobi3/mDYMEDOE92dnNRD2ChNXg2IuvAL4OW40wh gXlkHC1ZgToNGoYVvGcZFug1NI+vCeCFchX+L3bXyLMg3rAfWMFPAZLzn42plIDMsBs+x2yP +bkCDQRWBSYZARAAvFJBFuX9A6eayxUPFaEczlMbGXugs0mazbOYGlyaWsiyfyc3PStHLFPj rSTaeJpPCjBJErwpZUN4BbpkBpaJiMuVO6egrC8Xy8/cnJakHPR2JPEvmj7Gm/L9DphTcE15 92rxXLesWzGBbuYxKsj8LEnrrvLyi3kNW6B5LY3Id+ZmU8YTQ2zLuGV5tLiWKKxc6s3eMXNq wrJTCzdVd6ThXrmUfAHbcFXOycUyf9vD+s+WKpcZzCXwKgm7x1LKsJx3UhuzT8ier1L363RW ZaJBZ9CTPiu8R5NCSn9V+BnrP3wlFbtLqXp6imGhazT9nJF86b5BVKpF8Vl3F0/Y+UZ4gUwL d9cmDKBcmQU/JaRUSWvvolNu1IewZZu3rFSVgcpdaj7F/1aC0t5vLdx9KQRyEAKvEOtCmP4m 38kU/6r33t3JuTJnkigda4+Sfu5kYGsogeYG6dNyjX5wpK5GJIJikEhdkwcLM+BUOOTi+I9u tX03BGSZo7FW/J7S9y0l5a8nooDs2gBRGmUgYKqQJHCDQyYut+hmcr+BGpUn9/pp2FTWijrP inb/Pc96YDQLQA1q2AeAFv3Rx3XoBTGl0RCY4KZ02c0kX/dm3eKfMX40XMegzlXCrqtzUk+N 8LeipEsnOoAQcEONAWWo1HcgUIgCjhJhBEF0AcELOQzitbJGG5UAEQEAAYkCHwQYAQIACQUC VgUmGQIbDAAKCRDzDDi9Py++PCD3D/9VCtydWDdOyMTJvEMRQGbx0GacqpydMEWbE3kUW0ha US5jz5gyJZHKR3wuf1En/3z+CEAEfP1M3xNGjZvpaKZXrgWaVWfXtGLoWAVTfE231NMQKGoB w2Dzx5ivIqxikXB6AanBSVpRpoaHWb06tPNxDL6SVV9lZpUn03DSR6gZEZvyPheNWkvz7bE6 FcqszV/PNvwm0C5Ju7NlJA8PBAQjkIorGnvN/vonbVh5GsRbhYPOc/JVwNNr63P76rZL8Gk/ hb3xtcIEi5CCzab45+URG/lzc6OV2nTj9Lg0SNcRhFZ2ILE3txrmI+aXmAu26+EkxLLfqCVT ohb2SffQha5KgGlOSBXustQSGH0yzzZVZb+HZPEvx6d/HjQ+t9sO1bCpEgPdZjyMuuMp9N1H ctbwGdQM2Qb5zgXO+8ZSzwC+6rHHIdtcB8PH2j+Nd88dVGYlWFKZ36ELeZxD7iJflsE8E8yg OpKgu3nD0ahBDqANU/ZmNNarBJEwvM2vfusmNnWm3QMIwxNuJghRyuFfx694Im1js0ZY3LEU JGSHFG4ZynA+ZFUPA6Xf0wHeJOxGKCGIyeKORsteIqgnkINW9fnKJw2pgk8qHkwVc3Vu+wGS ZiJK0xFusPQehjWTHn9WjMG1zvQ5TQQHxau/2FkP45+nRPco6vVFQe8JmgtRF8WFJA== Message-ID: <7da5b054-d378-10a7-f3a4-b3437baf00c3@vivier.eu> Date: Wed, 10 Jun 2020 19:33:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200608164357.25065-2-filip.bozuta@syrmia.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:cS7nJ2so2pBswIoHxz6VvEiQZiL57bCbqXMkwmRk/ftfFs0mTBm YDefzzCeyU/SF0GmVvy0xPsH1OQnxF5dfxUIjM4OdUVSNY3jL7HqW+vCVyRkyqsfpNCH2D8 Guzz6GxFZLGJq/l9ahph9lh0xpr8RXtVy6cR1pSsTJvyi6+3Z1bB9SnPK6Oyec7yjp5op4s 3kZ8UoiUeGY7Is3w4I8bg== X-UI-Out-Filterresults: notjunk:1;V03:K0:+hO74hEYFO8=:MLI9BjmEj7JwxiR1S+3kmw Lwq87X6LZNWFXOSgHJbBJg0jtuPp+LwiccbcwQCZwjI8XL4pqDVQ7YOyU2mdLK9AyT5V4FNaZ rzL2/EcoqlIvRGo8Z9xeCenBxNuYsS0ImyCQsxlVlj9fskx7bnzGWi44u2nO7wpEtpL2NjBvP Nk2XjpURWffnTgOXXPpZ8/kPFxR2ZOCU+18tDy6Ih0PjSdzZJvp4kNfWyoXBGdIf0OM6138bU 1vq4Yuqq6TjNM2t63WpkM9A7+/+U4hgOPqXpfrEdV8One26SEpDxifB8gxIpJnXBg5daAmoAf QKFI8rTxKnuDEdaEeGFntVvSSxV6Z8huE37ASOfDf66fRDIIP8IFAjIu5xy7HLiOlZSpBLGuF kwjNliCbhdSsqa3xjvYSXNHHcXZYA3KZuiLjyyzsdAOH6cTjvDBN6Cj+dmHWwIDAJUV5V35LG c/NJeHixOw06tjVUjJ8/MTLThfTwwJrr4rXVD7hOWatQHnBHTE03kt0Qhmla5rn28Mx+lovoH Ju5NOUXGfIlYNmv+c/mPu0c6bP6Qiu8YjMItqhIb7fCKSHBpTVrBWySEVB5drsr3JiTLbAox2 5ewWK1rIe4VMh3HUfTkUVLsvhpbqKE2iPPVKY4cqXJTwKdTC0ERfi5zzhTD5NZhZdgTTtfl1Y DCKCyP7H1ZN2ZrfIUeOzVa3Bq+P3/ZLnMW8oXgVFxX1zvt3ahhdlaVQHIh908T0MmIxqvstbb TNQtiPjdHioDzaGwYvB6RTcEkIbMwUs1LOna1VS5t9N/JS8mIblGG4hbyqYBp2MYiDbGRd8Qf PIhy4GyA91zbYID3Bw751W/vSW0YFnki6huIjLfhHLYOnt631ZxSSZdV4GKhvlxAi8nCnhY Received-SPF: none client-ip=212.227.126.131; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/10 13:33:21 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 08/06/2020 à 18:43, Filip Bozuta a écrit : > From: Filip Bozuta > > Structure "struct syscallname" in file "strace.c" is used for "-strace" > to print arguments and return values of syscalls. The last field of > this structure "result" represents the calling function that prints the > return values. This field was extended in this patch so that this functions > takes all syscalls arguments beside the return value. In this way, it enables > "-strace" to print arguments of syscalls that have changed after the syscall > execution. This extension will be useful as there are many syscalls that > return values inside their arguments (i.e. listxattr() that returns the list > of extended attributes inside the "list" argument). > > Implementation notes: > > Since there are already three existing "print_syscall_ret*" functions inside > "strace.c" ("print_syscall_ret_addr()", "print_syscall_ret_adjtimex()", > "print_syscall_ret_newselect()"), they were changed to have all syscall arguments > beside the return value. This was done so that these functions don't cause build > errors (even though syscall arguments are not used in these functions). > > Signed-off-by: Filip Bozuta > --- > linux-user/qemu.h | 4 +++- > linux-user/strace.c | 24 ++++++++++++++++++------ > linux-user/syscall.c | 2 +- > 3 files changed, 22 insertions(+), 8 deletions(-) > Reviewed-by: Laurent Vivier