Re: [Qemu-devel] [PATCH 10/18] Include qapi/qmp/qlist.h exactly where needed

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1409 bytes --]

On 01/30/2018 04:21 AM, Markus Armbruster wrote:
> This cleanup makes the number of objects depending on qapi/qmp/qlist.h
> drop from 4548 (out of 4739) to 16 in my "build everything" tree.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---

> +++ b/tests/check-qdict.c
> @@ -9,9 +9,11 @@
>   * This work is licensed under the terms of the GNU LGPL, version 2.1 or later.
>   * See the COPYING.LIB file in the top-level directory.
>   */
> +
>  #include "qemu/osdep.h"

Another one of these whitespace cleanups around osdep.h that might be
worth collecting into its own patch.

>  
>  #include "qapi/qmp/qdict.h"
> +#include "qapi/qmp/qlist.h"
>  #include "qapi/qmp/qnum.h"
>  #include "qapi/qmp/qstring.h"
>  #include "qapi/error.h"

But at least it was in the same hunk as the actual meat of the commit.

> +++ b/tests/libqtest.c
> @@ -14,6 +14,7 @@
>   * See the COPYING file in the top-level directory.
>   *
>   */
> +
>  #include "qemu/osdep.h"
>  #include "libqtest.h"
>  
> @@ -25,6 +26,7 @@
>  #include "qapi/qmp/json-parser.h"
>  #include "qapi/qmp/json-streamer.h"
>  #include "qapi/qmp/qjson.h"
> +#include "qapi/qmp/qlist.h"
>  

In contrast to this location.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]