From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: qdev unrealize error handling WTF?!?
Date: Mon, 27 Apr 2020 15:44:29 +0200 [thread overview]
Message-ID: <7dcd7cb0-bf36-4980-194f-d2c3a65ba6ed@redhat.com> (raw)
In-Reply-To: <87k121hzva.fsf@dusky.pond.sub.org>
On 27/04/20 14:33, Markus Armbruster wrote:
> [1] a device on dev->child_bus fails to
> unrealize, or [3] @dev itself fails to unrealize. We hold on to the
> first failure, and continue to unrealize. device_set_realized() fails
> when any of these fail.
>
> Issue #1: What if some, but not all fail? How can this possibly work?
>
> Issue #2: Even if all fail, and therefore both the device and the ones
> on ->child_bus all remain realized, there are side effects at [2] and
> [4].
>
> Any better ideas than &error_abort?
I don't think we have unrealizes that fail, so removing the argument and
&error_abort is the best idea.
Paolo
prev parent reply other threads:[~2020-04-27 13:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 12:33 qdev unrealize error handling WTF?!? Markus Armbruster
2020-04-27 13:44 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dcd7cb0-bf36-4980-194f-d2c3a65ba6ed@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).