From: Thomas Huth <thuth@redhat.com>
To: Ani Sinha <anisinha@redhat.com>,
qemu-devel@nongnu.org, Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: mst@redhat.com, imammedo@redhat.com,
Michael Labiuk <michael.labiuk@virtuozzo.com>
Subject: Re: [PATCH v6 4/5] tests/qtest/hd-geo-test: fix incorrect pcie-root-port usage and simplify test
Date: Thu, 29 Jun 2023 09:03:22 +0200 [thread overview]
Message-ID: <7dd54a5e-ed28-0a5e-9ef0-5d3e8985c1f7@redhat.com> (raw)
In-Reply-To: <20230629040707.115656-5-anisinha@redhat.com>
On 29/06/2023 06.07, Ani Sinha wrote:
> The test attaches a SCSI controller to a non-zero slot and a pcie-to-pci bridge
> on slot 0 on the same pcie-root-port. Since a downstream device can be attached
> to a pcie-root-port only on slot 0, the above test configuration is not allowed.
> Additionally using pcie.0 as id for pcie-to-pci bridge is incorrect as that id
> is reserved only for the root bus.
>
> In the test scenario, there is no need to attach a pcie-root-port to the
> root complex. A SCSI controller can be attached to a pcie-to-pci bridge
> which can then be directly attached to the root bus (pcie.0).
>
> Fix the test and simplify it.
>
> CC: mst@redhat.com
> CC: imammedo@redhat.com
> CC: Michael Labiuk <michael.labiuk@virtuozzo.com>
>
> Signed-off-by: Ani Sinha <anisinha@redhat.com>
> ---
> tests/qtest/hd-geo-test.c | 18 ++++++++----------
> 1 file changed, 8 insertions(+), 10 deletions(-)
Acked-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2023-06-29 7:04 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 4:07 [PATCH v6 0/5] test and QEMU fixes to ensure proper PCIE device usage Ani Sinha
2023-06-29 4:07 ` [PATCH v6 1/5] tests/acpi: allow changes in DSDT.noacpihp table blob Ani Sinha
2023-06-29 4:07 ` [PATCH v6 2/5] tests/acpi/bios-tables-test: use the correct slot on the pcie-root-port Ani Sinha
2023-06-29 4:07 ` [PATCH v6 3/5] tests/acpi/bios-tables-test: update acpi blob q35/DSDT.noacpihp Ani Sinha
2023-06-29 4:07 ` [PATCH v6 4/5] tests/qtest/hd-geo-test: fix incorrect pcie-root-port usage and simplify test Ani Sinha
2023-06-29 7:03 ` Thomas Huth [this message]
2023-06-30 9:09 ` Igor Mammedov
2023-06-29 4:07 ` [PATCH v6 5/5] hw/pci: ensure PCIE devices are plugged into only slot 0 of PCIE port Ani Sinha
2023-06-29 6:47 ` Akihiko Odaki
2023-06-29 8:05 ` Ani Sinha
2023-06-29 8:49 ` Akihiko Odaki
2023-06-29 14:18 ` Ani Sinha
2023-06-30 2:43 ` Akihiko Odaki
2023-06-30 6:02 ` Michael S. Tsirkin
2023-06-30 7:41 ` Ani Sinha
2023-06-30 8:32 ` Michael S. Tsirkin
2023-06-30 8:36 ` Ani Sinha
2023-06-30 8:43 ` Michael S. Tsirkin
2023-06-30 9:22 ` Ani Sinha
2023-06-30 10:00 ` Michael S. Tsirkin
2023-06-30 10:37 ` Ani Sinha
2023-06-30 10:40 ` Michael S. Tsirkin
2023-06-30 10:45 ` Ani Sinha
2023-06-30 10:49 ` Ani Sinha
2023-06-30 11:36 ` Akihiko Odaki
2023-06-30 11:47 ` Ani Sinha
2023-06-30 11:55 ` Akihiko Odaki
2023-06-30 13:56 ` Ani Sinha
2023-07-01 7:09 ` Akihiko Odaki
2023-07-02 4:59 ` Michael S. Tsirkin
2023-07-03 6:08 ` Ani Sinha
2023-07-04 5:01 ` Akihiko Odaki
2023-07-04 5:39 ` Ani Sinha
2023-07-04 10:33 ` Ani Sinha
2023-07-04 10:36 ` Michael S. Tsirkin
2023-07-04 11:10 ` Ani Sinha
2023-07-03 13:31 ` Ani Sinha
2023-06-30 15:29 ` Michael S. Tsirkin
2023-07-01 7:28 ` Akihiko Odaki
2023-07-04 11:38 ` Igor Mammedov
2023-07-04 11:50 ` Akihiko Odaki
2023-07-04 12:36 ` Igor Mammedov
2023-07-04 12:51 ` Akihiko Odaki
2023-07-04 14:03 ` Ani Sinha
2023-07-05 2:30 ` Akihiko Odaki
2023-06-30 10:25 ` Michael S. Tsirkin
2023-06-29 14:24 ` Michael S. Tsirkin
2023-06-29 14:37 ` Ani Sinha
2023-06-29 15:32 ` Michael S. Tsirkin
2023-06-29 15:57 ` Ani Sinha
2023-06-29 16:45 ` Ani Sinha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dd54a5e-ed28-0a5e-9ef0-5d3e8985c1f7@redhat.com \
--to=thuth@redhat.com \
--cc=anisinha@redhat.com \
--cc=imammedo@redhat.com \
--cc=lvivier@redhat.com \
--cc=michael.labiuk@virtuozzo.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).