From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRorK-000191-48 for qemu-devel@nongnu.org; Mon, 25 Jul 2016 19:00:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bRorJ-0007LQ-3I for qemu-devel@nongnu.org; Mon, 25 Jul 2016 19:00:26 -0400 References: <1469182567-3114-1-git-send-email-wangww.fnst@cn.fujitsu.com> <1469182567-3114-11-git-send-email-wangww.fnst@cn.fujitsu.com> From: Max Reitz Message-ID: <7e07b40d-b0b8-1a2a-e446-007316deba67@redhat.com> Date: Tue, 26 Jul 2016 01:00:12 +0200 MIME-Version: 1.0 In-Reply-To: <1469182567-3114-11-git-send-email-wangww.fnst@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3NTreBRsBiOQo3HjWUrs5HiR7k3H6CLsP" Subject: Re: [Qemu-devel] [PATCH v22 10/10] support replication driver in blockdev-add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wang WeiWei , qemu devel , qemu block , Stefan Hajnoczi , Fam Zheng , Kevin Wolf , Jeff Cody Cc: Paolo Bonzini , John Snow , Eric Blake , Markus Armbruster , "Dr. David Alan Gilbert" , Dong Eddie , Jiang Yunhong , zhanghailiang , Gonglei , Wen Congyang , Changlong Xie This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3NTreBRsBiOQo3HjWUrs5HiR7k3H6CLsP From: Max Reitz To: Wang WeiWei , qemu devel , qemu block , Stefan Hajnoczi , Fam Zheng , Kevin Wolf , Jeff Cody Cc: Paolo Bonzini , John Snow , Eric Blake , Markus Armbruster , "Dr. David Alan Gilbert" , Dong Eddie , Jiang Yunhong , zhanghailiang , Gonglei , Wen Congyang , Changlong Xie Message-ID: <7e07b40d-b0b8-1a2a-e446-007316deba67@redhat.com> Subject: Re: [PATCH v22 10/10] support replication driver in blockdev-add References: <1469182567-3114-1-git-send-email-wangww.fnst@cn.fujitsu.com> <1469182567-3114-11-git-send-email-wangww.fnst@cn.fujitsu.com> In-Reply-To: <1469182567-3114-11-git-send-email-wangww.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 22.07.2016 12:16, Wang WeiWei wrote: > From: Wen Congyang >=20 > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Signed-off-by: Changlong Xie > Reviewed-by: Eric Blake > Signed-off-by: Wang WeiWei > --- > qapi/block-core.json | 19 +++++++++++++++++-- > 1 file changed, 17 insertions(+), 2 deletions(-) >=20 > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 7f05b68..59565e9 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -248,6 +248,7 @@ > # 2.3: 'host_floppy' deprecated > # 2.5: 'host_floppy' dropped > # 2.6: 'luks' added > +# 2.7: 'replication' added Probably 2.8 > # > # @backing_file: #optional the name of the backing file (for copy-on-w= rite) > # > @@ -1696,8 +1697,8 @@ > 'data': [ 'archipelago', 'blkdebug', 'blkverify', 'bochs', 'cloop', > 'dmg', 'file', 'ftp', 'ftps', 'gluster', 'host_cdrom', > 'host_device', 'http', 'https', 'luks', 'null-aio', 'null-= co', > - 'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw', 'tft= p', > - 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] } > + 'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw', 'rep= lication', > + 'tftp', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] } > =20 > ## > # @BlockdevOptionsFile > @@ -2160,6 +2161,19 @@ > { 'enum' : 'ReplicationMode', 'data' : [ 'primary', 'secondary' ] } > =20 > ## > +# @BlockdevOptionsReplication > +# > +# Driver specific block device options for replication > +# > +# @mode: the replication mode What about top-id? > +# > +# Since: 2.7 2.8 Max > +## > +{ 'struct': 'BlockdevOptionsReplication', > + 'base': 'BlockdevOptionsGenericFormat', > + 'data': { 'mode': 'ReplicationMode' } } > + > +## > # @BlockdevOptions > # > # Options for creating a block device. Many options are available for= all > @@ -2224,6 +2238,7 @@ > 'quorum': 'BlockdevOptionsQuorum', > 'raw': 'BlockdevOptionsGenericFormat', > # TODO rbd: Wait for structured options > + 'replication':'BlockdevOptionsReplication', > # TODO sheepdog: Wait for structured options > # TODO ssh: Should take InetSocketAddress for 'host'? > 'tftp': 'BlockdevOptionsFile', >=20 --3NTreBRsBiOQo3HjWUrs5HiR7k3H6CLsP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEvBAEBCAAZBQJXlpn8EhxtcmVpdHpAcmVkaGF0LmNvbQAKCRA7sUIC6DisrY1R B/wOAfIgMoldUJxaCU4T37VFa75+mNfmPXPsgW0DZTalxWtlCj84/4CaDeLQvqW8 Xl8rnJpRB29kM4nBh7B5+uAZOPKz2bHaoEM7B2b2AhH+sIHJ4mLyW0tSZfmMFwsu iiCdO7iCHjTFOYMKK7S1NSfzp85YXrhkk4k+JDqPctqrlcY5EbkBuCEwdTKAhYHW NQXDaIktZ4wvg5biybzy2e9wXZh0hQJJOrX4O6Z93Rv5Ynr2OKwVwdYaEgYib1ST 0mhDm8hEAKFQkqHSlnDkcGgKzwll0ZZYB62fjvY73XH2FsyveFKg+7Ru0KGA6n7U gsnT8I4XRJbASlSI++gpMu4X =XTI9 -----END PGP SIGNATURE----- --3NTreBRsBiOQo3HjWUrs5HiR7k3H6CLsP--