qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 2/5] blkdebug: Add pass-through write_zero and discard support
Date: Tue, 6 Dec 2016 16:36:48 -0600	[thread overview]
Message-ID: <7e0db4e1-92b9-d14d-9785-f98379cf36f9@redhat.com> (raw)
In-Reply-To: <1d974cec-fefe-e4c9-f2b0-1d8231b229cd@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1793 bytes --]

On 12/06/2016 04:23 PM, Max Reitz wrote:
> On 06.12.2016 23:18, Eric Blake wrote:
>> On 12/06/2016 04:14 PM, Max Reitz wrote:
>>> On 06.12.2016 23:12, Eric Blake wrote:
>>>> On 12/06/2016 04:00 PM, Max Reitz wrote:
>>>>
>>>>>> Tested by setting up an NBD server with export 'foo', then invoking:
>>>>>> $ ./qemu-io
>>>>>> qemu-io> open -o driver=blkdebug blkdebug::nbd://localhost:10809/foo
>>>>
>>>> By the way, I'd LOVE to know if there is a way to write a qemu-io
>>>> command line that would do this connection automatically (so that I can
>>>> batch commands up front and benefit from the shell's history) rather
>>>> than having to issue an 'open' after the fact.  I tried various
>>>> incantations with --object and --image-opts, but got stumped.
>>>
>>> Can't you just do qemu-io -c 'open'?
>>
>> I suppose that would get command-line history.  But I still want
>> interactive mode.  The moment you use -c, ALL commands get run
>> back-to-back without stopping, so I'd have to add additional -c
>> 'read'/'write' commands up front. I like interactive mode (open
>> pre-connected, now let me explore the image at will).
> 
> Well, the usual --image-opts version would be:
> 
> ./qemu-io --image-opts driver=blkdebug,image.driver=nbd,\
> image.host=localhost,image.export=foo

Thanks, that appears to do the trick! I think I was getting confused by
trying 'file.driver' instead of 'image.driver', or maybe it was because
I was trying 'image.align' to set the blkdebug alignment where just
plain 'align' works once you are in --image-opts mode, or some such
problem on my end.  [Maybe I shouldn't be testing patches late at night,
either...]

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2016-12-06 22:37 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-02 19:22 [Qemu-devel] [PATCH v3 0/5] add blkdebug tests Eric Blake
2016-12-02 19:22 ` [Qemu-devel] [PATCH v3 1/5] blkdebug: Sanity check block layer guarantees Eric Blake
2016-12-06 21:26   ` Max Reitz
2016-12-07 16:17   ` Kevin Wolf
2016-12-02 19:22 ` [Qemu-devel] [PATCH v3 2/5] blkdebug: Add pass-through write_zero and discard support Eric Blake
2016-12-06 22:00   ` Max Reitz
2016-12-06 22:12     ` Eric Blake
2016-12-06 22:14       ` Max Reitz
2016-12-06 22:18         ` Eric Blake
2016-12-06 22:23           ` Max Reitz
2016-12-06 22:36             ` Eric Blake [this message]
2016-12-07 13:55   ` Kevin Wolf
2016-12-07 15:15     ` Eric Blake
2016-12-02 19:22 ` [Qemu-devel] [PATCH v3 3/5] blkdebug: Simplify override logic Eric Blake
2016-12-06 22:10   ` Max Reitz
2016-12-06 22:15     ` Eric Blake
2016-12-07 16:17   ` Kevin Wolf
2016-12-02 19:22 ` [Qemu-devel] [PATCH v3 4/5] blkdebug: Add ability to override unmap geometries Eric Blake
2016-12-06 22:31   ` Max Reitz
2016-12-07 14:35   ` Kevin Wolf
2016-12-07 15:11     ` Eric Blake
2016-12-02 19:22 ` [Qemu-devel] [PATCH v3 5/5] tests: Add coverage for recent block geometry fixes Eric Blake
2016-12-06 22:33   ` Max Reitz
2016-12-07 16:16   ` Kevin Wolf
2016-12-07 16:34     ` Eric Blake
2016-12-20 16:42       ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e0db4e1-92b9-d14d-9785-f98379cf36f9@redhat.com \
    --to=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).