From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40127)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1beHsf-0007IB-SG
	for qemu-devel@nongnu.org; Mon, 29 Aug 2016 04:25:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1beHsf-0004Yz-0H
	for qemu-devel@nongnu.org; Mon, 29 Aug 2016 04:25:21 -0400
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1472457138-23386-1-git-send-email-ronyweng@synology.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <7e0e5c6b-dab7-7b87-2f4d-e07c3b64cef5@redhat.com>
Date: Mon, 29 Aug 2016 10:25:08 +0200
MIME-Version: 1.0
In-Reply-To: <1472457138-23386-1-git-send-email-ronyweng@synology.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Chage disk serial length from 20 to 36
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: ronyweng@synology.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org



On 29/08/2016 09:52, ronyweng@synology.com wrote:
> From: ronyweng <ronyweng@synology.com>
> 
> Openstack Cinder assigns volume a 36 characters uuid as serial.
> Qemu will shrinks the uuid to 20 characters,
> missmatch with original uuid.
> 
> Signed-off-by: Rony Weng <ronyweng@synology.com>
> ---
>  hw/scsi/scsi-disk.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c
> index 836a155..0e1bb68 100644
> --- a/hw/scsi/scsi-disk.c
> +++ b/hw/scsi/scsi-disk.c
> @@ -599,8 +599,8 @@ static int scsi_disk_emulate_inquiry(SCSIRequest *req, uint8_t *outbuf)
>              }
>  
>              l = strlen(s->serial);
> -            if (l > 20) {
> -                l = 20;
> +            if (l > 36) {
> +                l = 36;
>              }
>  
>              DPRINTF("Inquiry EVPD[Serial number] "
> 

Cc: qemu-stable@nongnu.org

Thanks, queued for 2.8 and 2.7.1

Paolo