From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drPrn-0001PV-DZ for qemu-devel@nongnu.org; Mon, 11 Sep 2017 10:39:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drPrj-0007QV-A6 for qemu-devel@nongnu.org; Mon, 11 Sep 2017 10:39:15 -0400 References: <20170911110037.6567-1-lvivier@redhat.com> <20170911110615.GK21444@redhat.com> <20170911134158.1f046176.cohuck@redhat.com> <20170911114347.GL21444@redhat.com> <20170911120441.GB2857@work-vm> <616d2319-1198-5a20-ebf4-ac2c532352db@redhat.com> <20170911121356.GN21444@redhat.com> <33a05e8f-0c26-b41c-e4ca-e602d67bb638@redhat.com> From: Thomas Huth Message-ID: <7e17b567-49c6-3c03-9a84-8abb8d6f8386@redhat.com> Date: Mon, 11 Sep 2017 16:39:05 +0200 MIME-Version: 1.0 In-Reply-To: <33a05e8f-0c26-b41c-e4ca-e602d67bb638@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] hmp: fix "dump-quest-memory" segfault (ppc) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , "Daniel P. Berrange" Cc: "Dr. David Alan Gilbert" , Cornelia Huck , David Gibson , qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 11.09.2017 14:15, Laurent Vivier wrote: > On 11/09/2017 14:13, Daniel P. Berrange wrote: >> On Mon, Sep 11, 2017 at 02:10:14PM +0200, Laurent Vivier wrote: >>> On 11/09/2017 14:04, Dr. David Alan Gilbert wrote: >>>> * Daniel P. Berrange (berrange@redhat.com) wrote: >>>>> On Mon, Sep 11, 2017 at 01:41:58PM +0200, Cornelia Huck wrote: >>>>>> On Mon, 11 Sep 2017 12:06:15 +0100 >>>>>> "Daniel P. Berrange" wrote: >>>>>> >>>>>>> On Mon, Sep 11, 2017 at 01:00:37PM +0200, Laurent Vivier wrote: >>>>>>>> Commit fd5d23babf (hmp: fix "dump-quest-memory" segfault) >>>>>>>> fixes the problem for i386, do the same for ppc. >>>>>>> >>>>>>> What about all the other targets QEMU supports ? Have you checked if they >>>>>>> are similarly affected, as we don't want to wait another 6 months to get a >>>>>>> bug report that s390 or aarch64 crash in exactly the same way too. >>>>>> >>>>>> This patch actually prompted me to check s390, and the mentioned >>>>>> command line works fine. >>>>>> >>>>>> However, if we start a qemu with no guest memory defined and then call >>>>>> dump-guest-memory without filtering, we get a core dump instead of a >>>>>> guest dump (s390x or x86_64, machine none). >>>>>> >>>>>> I can take a stab at fixing that, unless someone beats me to it. >>>>> >>>>> I wonder if someone wants to write a qtest job to run dump-guest-memory >>>>> across all machine types, on all targets. Seems we have enough crashiness >>>>> in this code to make it worthwhile to test >>>> >>>> We do have - that's how we found this case; it's part of test-hmp. >>> >>> The test-hmp runs by default with 0 MB of memory, the problem can only >>> be found with some memory added to the machine. >>> >>> Perhaps we can simply update the test to add memory? >> >> Probably best to run it twice, 0MB and with say 2MB, as they're both >> fairly magic values. > > OK, I'm going to update the test. Thanks! But please note that it is only the "none" machine which is started without memory and CPU by default - all the other boards should have a default set of memory and at least one CPU. So we should only add an additional tests for the "none" machine here. Thomas