Re: [Qemu-devel] [PATCH 1/3] qcow2: Fix unaligned preallocated truncation

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1032 bytes --]

On 10/09/2017 04:55 PM, Max Reitz wrote:
> A qcow2 image file's length is not required to have a length that is a
> multiple of the cluster size.  However, qcow2_refcount_area() expects an
> aligned value for its @start_offset parameter, so we need to round
> @old_file_size up to the next cluster boundary.
> 
> Reported-by: pingl <pingl@redhat.com>

Should we use a real name? My autocomplete when adding cc suggests Ping Li.

(The upcoming git 2.15.0 adds my patch that auto-cc's anyone listed in
Reported-by, so we don't have to keep doing it manually:
https://github.com/git/git/commit/09ac6737 - but that doesn't help you
while you are still on 2.13.6)

> Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1414049
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  block/qcow2.c | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]