From: Eric Blake <eblake@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Sergio Andres Gomez Del Real <sergio.g.delreal@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-options: Add missing newline to -accel help text
Date: Mon, 11 Jun 2018 15:05:23 -0500 [thread overview]
Message-ID: <7e40b530-d59b-5d4e-8b34-9ebb0ce142b1@redhat.com> (raw)
In-Reply-To: <20180611195607.3015-1-ehabkost@redhat.com>
On 06/11/2018 02:56 PM, Eduardo Habkost wrote:
> The newline was removed by commit c97d6d2c, and broke -help output:
-help output is not supposed to be parsed by machine, in part because of
stuff like this ;)
>
> Before this patch:
>
> $ qemu-system-x86_64 -help | grep smp
> thread=single|multi (enable multi-threaded TCG)-smp [...]
>
> After this patch:
>
> $ qemu-system-x86_64 -help | grep smp
> -smp [cpus=]n[,maxcpus=cpus][,cores=cores][,threads=threads][,sockets=sockets]
>
> Fixes: c97d6d2cdf97edb4aebe832fdba65d701ad7bcb6
> Cc: Sergio Andres Gomez Del Real <sergio.g.delreal@gmail.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
But for the humans, this is a definite mistake worth fixing.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-06-11 20:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 19:56 [Qemu-devel] [PATCH] qemu-options: Add missing newline to -accel help text Eduardo Habkost
2018-06-11 20:05 ` Eric Blake [this message]
2018-06-21 10:01 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e40b530-d59b-5d4e-8b34-9ebb0ce142b1@redhat.com \
--to=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sergio.g.delreal@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).