From: Tao Xu <tao3.xu@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
"rth@twiddle.net" <rth@twiddle.net>,
"ehabkost@redhat.com" <ehabkost@redhat.com>,
"mtosatti@redhat.com" <mtosatti@redhat.com>
Cc: "Liu, Jingqi" <jingqi.liu@intel.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH v5 1/2] x86/cpu: Add support for UMONITOR/UMWAIT/TPAUSE
Date: Wed, 9 Oct 2019 16:21:35 +0800 [thread overview]
Message-ID: <7e43e268-d94e-a66f-9254-3de03313a064@intel.com> (raw)
In-Reply-To: <6762960d-80a6-be31-399d-f62e33b31f28@redhat.com>
On 10/9/2019 4:06 PM, Paolo Bonzini wrote:
> On 29/09/19 03:57, Tao Xu wrote:
>> + } else if (function == 7 && index == 0 && reg == R_ECX) {
>> + if (enable_cpu_pm) {
>> + ret |= CPUID_7_0_ECX_WAITPKG;
>
> This is incorrect. You should disable WAITPKG if !enable_cpu_pm, but
> you should not enable it forcefully if enable_cpu_pm is true.
>
> Paolo
>
>> + } else {
>> + ret &= ~CPUID_7_0_ECX_WAITPKG;
>> + }
>
Got it, thank you.
next prev parent reply other threads:[~2019-10-09 17:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-29 1:57 [PATCH v5 0/2] x86: Enable user wait instructions Tao Xu
2019-09-29 1:57 ` [PATCH v5 1/2] x86/cpu: Add support for UMONITOR/UMWAIT/TPAUSE Tao Xu
2019-10-09 8:06 ` Paolo Bonzini
2019-10-09 8:21 ` Tao Xu [this message]
2019-09-29 1:57 ` [PATCH v5 2/2] target/i386: Add support for save/load IA32_UMWAIT_CONTROL MSR Tao Xu
2019-10-09 1:03 ` [PATCH v5 0/2] x86: Enable user wait instructions Tao Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e43e268-d94e-a66f-9254-3de03313a064@intel.com \
--to=tao3.xu@intel.com \
--cc=ehabkost@redhat.com \
--cc=jingqi.liu@intel.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).