From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Bernhard Beschow <shentey@gmail.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-trivial@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Jean-Christophe Dubois <jcd@tribudubois.net>,
qemu-arm@nongnu.org, Andrey Smirnov <andrew.smirnov@gmail.com>,
Peter Xu <peterx@redhat.com>,
David Hildenbrand <david@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Mads Ynddal <mads@ynddal.dk>, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 4/6] hw/misc/imx6_ccm: Convert DPRINTF to trace events
Date: Mon, 30 Oct 2023 04:23:54 +0100 [thread overview]
Message-ID: <7e52e29c-46c8-483c-cf5a-b6e6ca18c655@linaro.org> (raw)
In-Reply-To: <20231028122415.14869-5-shentey@gmail.com>
Hi Bernhard,
On 28/10/23 14:24, Bernhard Beschow wrote:
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
> hw/misc/imx6_ccm.c | 41 ++++++++++++++---------------------------
> hw/misc/trace-events | 15 +++++++++++++++
> 2 files changed, 29 insertions(+), 27 deletions(-)
> +# imx6_ccm.c
> +imx6_analog_get_periph_clk(uint32_t freq) "freq = %u"
Preferably explicit the unit, as "freq = %u Hz".
> +imx6_analog_get_pll2_clk(uint32_t freq) "freq = %u"
> +imx6_analog_get_pll2_pfd0_clk(uint32_t freq) "freq = %u"
> +imx6_analog_get_pll2_pfd2_clk(uint32_t freq) "freq = %u"
> +imx6_ccm_get_ahb_clk(uint32_t freq) "freq = %u"
> +imx6_ccm_get_ipg_clk(uint32_t freq) "freq = %u"
> +imx6_ccm_get_per_clk(uint32_t freq) "freq = %u"
> +imx6_ccm_get_clock_frequency(unsigned clock, uint32_t freq) "(Clock = %d) = %u"
'freq' is uint64_t, but I suppose 32-bit is enough, so I'm
not against the implicit cast.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-10-30 3:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-28 12:24 [PATCH 0/6] Various tracing patches Bernhard Beschow
2023-10-28 12:24 ` [PATCH 1/6] hw/watchdog/wdt_imx2: Trace MMIO access Bernhard Beschow
2023-10-30 3:17 ` Philippe Mathieu-Daudé
2023-10-28 12:24 ` [PATCH 2/6] hw/watchdog/wdt_imx2: Trace timer activity Bernhard Beschow
2023-10-28 12:24 ` [PATCH 3/6] hw/misc/imx7_snvs: Trace MMIO access Bernhard Beschow
2023-10-30 3:18 ` Philippe Mathieu-Daudé
2023-10-28 12:24 ` [PATCH 4/6] hw/misc/imx6_ccm: Convert DPRINTF to trace events Bernhard Beschow
2023-10-30 3:23 ` Philippe Mathieu-Daudé [this message]
2023-10-28 12:24 ` [PATCH 5/6] hw/i2c/pm_smbus: " Bernhard Beschow
2023-10-30 3:25 ` Philippe Mathieu-Daudé
2023-10-31 22:08 ` Corey Minyard
2023-10-28 12:24 ` [PATCH 6/6] system/memory: Trace names of MemoryRegions rather than host pointers Bernhard Beschow
2023-10-30 3:36 ` Philippe Mathieu-Daudé
2023-11-02 9:05 ` Bernhard Beschow
2023-10-31 16:17 ` [PATCH 0/6] Various tracing patches Peter Maydell
2023-11-01 17:37 ` Bernhard Beschow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e52e29c-46c8-483c-cf5a-b6e6ca18c655@linaro.org \
--to=philmd@linaro.org \
--cc=andrew.smirnov@gmail.com \
--cc=david@redhat.com \
--cc=jcd@tribudubois.net \
--cc=mads@ynddal.dk \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=shentey@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).