From: Hanna Reitz <hreitz@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-block@nongnu.org, Cleber Rosa <crosa@redhat.com>
Subject: Re: [PATCH 14/15] python/aqmp: Remove scary message
Date: Fri, 17 Sep 2021 16:38:56 +0200 [thread overview]
Message-ID: <7e77d482-3ba1-06b4-6c6d-0bafb9ff7e2f@redhat.com> (raw)
In-Reply-To: <20210917054047.2042843-15-jsnow@redhat.com>
On 17.09.21 07:40, John Snow wrote:
> The scary message interferes with the iotests output. Coincidentally, if
> iotests works by removing this, then it's good evidence that we don't
> really need to scare people away from using it.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/qemu/aqmp/__init__.py | 14 --------------
> 1 file changed, 14 deletions(-)
I definitely won’t give an R-b for this one, because that would require
me reviewing the AQMP series, and, well, you know.
Also, if I were to review the AQMP series and could actually give R-bs
in good faith, why would I accept adding this message? I mean, if I’d
reviewed it, I’d’ve had to trust it.
So, öhm, I’m fine with dropping this message because evidently I’d’ve
never agreed to adding it in the first place (had I reviewed the AQMP
series).
Hanna
next prev parent reply other threads:[~2021-09-17 14:52 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 5:40 [PATCH 00/15] Switch iotests to using Async QMP John Snow
2021-09-17 5:40 ` [PATCH 01/15] python/aqmp: add greeting property to QMPClient John Snow
2021-09-17 12:20 ` Hanna Reitz
2021-09-17 5:40 ` [PATCH 02/15] python/aqmp: add .empty() method to EventListener John Snow
2021-09-17 12:25 ` Hanna Reitz
2021-09-17 5:40 ` [PATCH 03/15] python/aqmp: Return cleared events from EventListener.clear() John Snow
2021-09-17 12:36 ` Hanna Reitz
2021-09-17 17:19 ` John Snow
2021-10-04 9:03 ` Hanna Reitz
2021-09-17 5:40 ` [PATCH 04/15] python/qmp: clear events on get_events() call John Snow
2021-09-17 12:51 ` Hanna Reitz
2021-09-17 17:31 ` John Snow
2021-09-17 5:40 ` [PATCH 05/15] python/qmp: add send_fd_scm directly to QEMUMonitorProtocol John Snow
2021-09-17 13:21 ` Hanna Reitz
2021-09-17 17:36 ` John Snow
2021-09-17 5:40 ` [PATCH 06/15] python, iotests: remove socket_scm_helper John Snow
2021-09-17 13:24 ` Hanna Reitz
2021-09-17 5:40 ` [PATCH 07/15] python/aqmp: add send_fd_scm John Snow
2021-09-17 13:34 ` Hanna Reitz
2021-09-17 18:05 ` John Snow
2021-09-17 5:40 ` [PATCH 08/15] python/aqmp: Create MessageModel and StandaloneModel classes John Snow
2021-09-17 13:39 ` Hanna Reitz
2021-09-17 19:21 ` John Snow
2021-09-17 5:40 ` [PATCH 09/15] python/machine: remove has_quit argument John Snow
2021-09-17 13:59 ` Hanna Reitz
2021-09-17 23:12 ` John Snow
2021-09-17 5:40 ` [PATCH 10/15] python/machine: Add support for AQMP backend John Snow
2021-09-17 14:16 ` Hanna Reitz
2021-09-17 23:48 ` John Snow
2021-10-04 9:43 ` Hanna Reitz
2021-09-17 5:40 ` [PATCH 11/15] python/aqmp: Create sync QMP wrapper for iotests John Snow
2021-09-17 14:23 ` Hanna Reitz
2021-09-18 0:01 ` John Snow
2021-09-17 5:40 ` [PATCH 12/15] iotests: Disable AQMP logging under non-debug modes John Snow
2021-09-17 14:30 ` Hanna Reitz
2021-09-18 0:58 ` John Snow
2021-09-18 2:14 ` John Snow
2021-10-04 10:12 ` Hanna Reitz
2021-10-04 18:32 ` John Snow
2021-10-04 21:26 ` John Snow
2021-10-05 15:12 ` Hanna Reitz
2021-10-04 9:52 ` Hanna Reitz
2021-09-17 5:40 ` [PATCH 13/15] iotests: Accommodate async QMP Exception classes John Snow
2021-09-17 14:35 ` Hanna Reitz
2021-09-18 1:12 ` John Snow
2021-09-17 5:40 ` [PATCH 14/15] python/aqmp: Remove scary message John Snow
2021-09-17 14:38 ` Hanna Reitz [this message]
2021-09-17 15:15 ` John Snow
2021-09-17 5:40 ` [PATCH 15/15] python, iotests: replace qmp with aqmp John Snow
2021-09-17 14:40 ` Hanna Reitz
2021-09-17 14:55 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e77d482-3ba1-06b4-6c6d-0bafb9ff7e2f@redhat.com \
--to=hreitz@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).