qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Warner Losh <imp@bsdimp.com>, qemu-devel@nongnu.org
Cc: jrtc27@FreeBSD.org, def@freebsd.org, arrowd@freebsd.org,
	Kyle Evans <kevans@freebsd.org>, Stacey Son <sson@FreeBSD.org>
Subject: Re: [PATCH v2 6/6] bsd-user/freebsd/os-syscall.c: Implement exit
Date: Thu, 9 Jun 2022 07:15:41 -0700	[thread overview]
Message-ID: <7e7edf85-e5b5-041f-384e-c2c4b2bc3be5@linaro.org> (raw)
In-Reply-To: <20220608211711.56158-7-imp@bsdimp.com>

On 6/8/22 14:17, Warner Losh wrote:
> +static inline abi_long do_bsd_exit(void *cpu_env, abi_long arg1)
> +{
> +#ifdef TARGET_GPROF
> +    _mcleanup();
> +#endif
> +    gdb_exit(arg1);
> +    qemu_plugin_user_exit();
> +    /* XXX: should free thread stack and CPU env here  */
> +    _exit(arg1);
> +

I think you can ditch the comment.  There's no point in that just before exit.


r~


  reply	other threads:[~2022-06-09 15:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-08 21:17 [PATCH v2 0/6] bsd-user upstreaming: read, write and exit Warner Losh
2022-06-08 21:17 ` [PATCH v2 1/6] bsd-user/freebsd/os-syscall.c: lock_iovec Warner Losh
2022-06-08 21:17 ` [PATCH v2 2/6] bsd-user/freebsd/os-syscall.c: unlock_iovec Warner Losh
2022-06-08 21:17 ` [PATCH v2 3/6] bsd-user/freebsd/os-syscall.c: Tracing and error boilerplate Warner Losh
2022-06-08 21:17 ` [PATCH v2 4/6] bsd-user/bsd-file.h: Add implementations for read, pread, readv and preadv Warner Losh
2022-06-08 21:17 ` [PATCH v2 5/6] bsd-user/bsd-file.h: Meat of the write system calls Warner Losh
2022-06-08 21:17 ` [PATCH v2 6/6] bsd-user/freebsd/os-syscall.c: Implement exit Warner Losh
2022-06-09 14:15   ` Richard Henderson [this message]
2022-06-09 14:16 ` [PATCH v2 0/6] bsd-user upstreaming: read, write and exit Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e7edf85-e5b5-041f-384e-c2c4b2bc3be5@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=arrowd@freebsd.org \
    --cc=def@freebsd.org \
    --cc=imp@bsdimp.com \
    --cc=jrtc27@FreeBSD.org \
    --cc=kevans@freebsd.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sson@FreeBSD.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).