From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B931C4360C for ; Fri, 27 Sep 2019 17:24:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F34F9207FF for ; Fri, 27 Sep 2019 17:24:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F34F9207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDtyd-0007SX-RJ for qemu-devel@archiver.kernel.org; Fri, 27 Sep 2019 13:24:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40335) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDsmy-000286-HM for qemu-devel@nongnu.org; Fri, 27 Sep 2019 12:08:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iDsmv-0004Nm-TZ for qemu-devel@nongnu.org; Fri, 27 Sep 2019 12:08:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44585) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iDsmv-0004La-N2 for qemu-devel@nongnu.org; Fri, 27 Sep 2019 12:08:09 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 660FE7BDAC; Fri, 27 Sep 2019 16:08:08 +0000 (UTC) Received: from [10.3.116.249] (ovpn-116-249.phx2.redhat.com [10.3.116.249]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 139CB5C224; Fri, 27 Sep 2019 16:08:02 +0000 (UTC) Subject: Re: [PATCH v2 22/26] qapi: Improve reporting of invalid 'if' further To: Markus Armbruster , qemu-devel@nongnu.org References: <20190927134639.4284-1-armbru@redhat.com> <20190927134639.4284-23-armbru@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <7e91d78e-8799-f5dd-e091-77d701ec1e22@redhat.com> Date: Fri, 27 Sep 2019 11:08:01 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20190927134639.4284-23-armbru@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 27 Sep 2019 16:08:08 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marcandre.lureau@redhat.com, mdroth@linux.vnet.ibm.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/27/19 8:46 AM, Markus Armbruster wrote: > check_if()'s errors don't point to the offending part of the > expression. For instance: > > tests/qapi-schema/alternate-branch-if-invalid.json:2: 'if' condition ' ' makes no sense > > Other check_FOO() do, with the help of a @source argument. Make > check_if() do that, too. The example above improves to: > > tests/qapi-schema/alternate-branch-if-invalid.json:2: 'if' condition ' ' of 'data' member 'branch' makes no sense > > Signed-off-by: Markus Armbruster > --- Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org