qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>
Cc: "Thomas Huth" <thuth@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Willian Rampazzo" <wrampazz@redhat.com>,
	"Cleber Rosa" <crosa@redhat.com>
Subject: Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure
Date: Wed, 15 Sep 2021 10:40:35 +0200	[thread overview]
Message-ID: <7e9ad0c4-e27f-42f4-fc82-56d16d3d3953@redhat.com> (raw)
In-Reply-To: <YUGu1PbzB+pzZdjf@redhat.com>

On 9/15/21 10:29 AM, Daniel P. Berrangé wrote:
> On Tue, Sep 14, 2021 at 08:17:19PM +0100, Peter Maydell wrote:
>> On Mon, 13 Sept 2021 at 11:19, Peter Maydell <peter.maydell@linaro.org> wrote:
>>>
>>> Currently we define a lot of jobs for our custom runners:
>>> for both aarch64 and s390x we have
>>>  - all-linux-static
>>>  - all
>>>  - alldbg
>>>  - clang (manual)
>>>  - tci
>>>  - notcg (manual)
>>>
>>> This is overkill.  The main reason to run on these hosts is to get
>>> coverage for the host architecture; we can leave the handling of
>>> differences like debug vs non-debug to the x86 CI jobs.
>>>
>>> The jobs are also generally running OK; they occasionally fail due to
>>> timeouts, which is likely because we're overloading the machine by
>>> asking it to run 4 CI jobs at once plus the ad-hoc CI.
>>>
>>> Remove the 'allow_failure' tag from all these jobs, and switch the
>>> s390x-alldbg, aarch64-all, s390x-tci and aarch64-tci jobs to manual.
>>> This will let us make the switch for s390x and aarch64 hosts from
>>> the ad-hoc CI to gitlab.
>>>
>>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>>
>> It looks like this change has resulted in pipelines ending
>> up in a "blocked" state:
>>
>> https://gitlab.com/qemu-project/qemu/-/pipelines
>>
>> I'm not sure why this is -- is it perhaps because there were
>> other jobs that depended on the now-manual-only jobs ?
>> Can somebody suggest a fix ?
> 
> Urgh, my bad, I completely forget this behaviour when reviewing.
> When we only have
> 
>   when: manual
> 
> then the job has to be manually started, and it still contributes
> to pipeline status, so it /must/ triggered manually.
> 
> If we want it to be manually started and not contribute to the
> pipeline status we need:
> 
>  rules:
>    ...
>    when: manual
>    allow_failure: true

Reminds me of the following commits:
- d3a4e41da25 ("gitlab-ci: Fix 'when:' condition in acceptance...")
- 59e8b62b220 ("gitlab-ci: Fix 'when:' condition in EDK2 jobs")
- c217fd8e36a ("gitlab-ci: Fix 'when:' condition in OpenSBI jobs")



  reply	other threads:[~2021-09-15  8:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13 10:19 [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure Peter Maydell
2021-09-13 10:28 ` Daniel P. Berrangé
2021-09-13 10:35   ` Peter Maydell
2021-09-13 10:40     ` Daniel P. Berrangé
2021-09-13 15:28 ` Willian Rampazzo
2021-09-14  5:44 ` Thomas Huth
2021-09-14 16:03 ` Peter Maydell
2021-09-14 19:17 ` Peter Maydell
2021-09-14 20:03   ` Willian Rampazzo
2021-09-15  8:29   ` Daniel P. Berrangé
2021-09-15  8:40     ` Philippe Mathieu-Daudé [this message]
2021-09-15 12:12     ` Peter Maydell
2021-09-15 12:16       ` Daniel P. Berrangé
2021-09-15 12:22         ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e9ad0c4-e27f-42f4-fc82-56d16d3d3953@redhat.com \
    --to=philmd@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=crosa@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wrampazz@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).